Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] sdl2: Update Nintendo Switch Pro Controller.cfg #1156

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
d82244b
Update and rename Nintendo Switch Pro Controller.cfg to Nintendo Co.,…
davidhedlund Jul 29, 2024
aa3f425
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund Jul 31, 2024
9500e76
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund Jul 31, 2024
d1471d8
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund Aug 1, 2024
e546bc7
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund Aug 1, 2024
9c9d1c2
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund Aug 2, 2024
35ddfdc
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund Aug 2, 2024
ecd06b4
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund Aug 20, 2024
e4157b0
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund Aug 20, 2024
660db38
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund Aug 20, 2024
6a60876
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund Aug 20, 2024
bc16a9f
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund Aug 20, 2024
29827b8
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund Aug 23, 2024
d55235a
Update Nintendo Co., Ltd. Pro Controller.cfg
davidhedlund Aug 23, 2024
ffbab5a
Rename Nintendo Co., Ltd. Pro Controller.cfg to Nintendo Switch Pro C…
davidhedlund Aug 24, 2024
fe785f1
Update Nintendo Switch Pro Controller.cfg
davidhedlund Aug 24, 2024
8e1b49c
Update Nintendo Switch Pro Controller.cfg
davidhedlund Aug 25, 2024
84338f7
Update Nintendo Switch Pro Controller.cfg
davidhedlund Sep 4, 2024
8c02cf1
Update Nintendo Switch Pro Controller.cfg
davidhedlund Sep 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 19 additions & 29 deletions sdl2/Nintendo Switch Pro Controller.cfg
Original file line number Diff line number Diff line change
@@ -1,35 +1,23 @@
# Nintendo Switch Pro Controller (with nintendo-hid)
# With nintendo-hid, various features such as vibration, gyro, and USB support are available. It appears this will be included in the Linux kernel beginning with version 5.16:
# "Pull HID updates from Jiri Kosina:
#
# - support for Nintendo Switch Pro Controllers and Joy-Cons (Daniel J.
# Ogorchock)" - https://cdn.kernel.org/pub/linux/kernel/v5.x/ChangeLog-5.16
#
# The easiest solution for most users is to install the nintendo-hid DKMS module, available from https://github.com/nicman23/dkms-hid-nintendo/

input_driver = "sdl2"
input_device = "Nintendo Switch Pro Controller"

input_vendor_id = "1406"
input_product_id = "8201"

input_a_btn = "1"
input_b_btn = "0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're flipping A/B. RetroArch uses A for right face button, and B for the bottom face button. Is this change correct? You can see a visual of it over at:
https://www.lakka.tv/doc/Input-settings/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct (just generated a test autoconfig to verify it for you), it's generated by RetroArch 1.19.1.

I am confident that every single binding in all pull requests is 100% correct. The only manual additions I've made are for the analog L2/R2 buttons on PlayStation controllers, specifically for drivers that didn't generate them in RetroArch. I maintain a detailed spreadsheet that tracks all controllers, drivers, manual bindings, and bug reports.

All autoconfigurations I've uploaded since the release of RetroArch 1.19.1 have been generated from that version. I've tested every autoconfig 2-3 times.

I'm certain that all pull requests can be approved without the need to merge them and potentially review everything again. I would prefer not to spend additional time on this, as it has already taken a significant amount of effort to reach this point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're flipping A/B. RetroArch uses A for right face button, and B for the bottom face button.

Since which RetroArch version (please give me a reference link if possible)?

input_x_btn = "2"
input_b_btn = "1"
input_y_btn = "3"
input_select_btn = "4"
input_start_btn = "6"
input_up_btn = "11"
input_down_btn = "12"
input_left_btn = "13"
input_right_btn = "14"
input_a_btn = "0"
input_x_btn = "2"
input_l_btn = "9"
input_r_btn = "10"
input_l2_axis = "+4"
input_r2_axis = "+5"
input_l3_btn = "7"
input_r3_btn = "8"
input_menu_toggle_btn = "5"
input_up_btn = "11"
input_down_btn = "12"
input_left_btn = "13"
input_right_btn = "14"
input_l_x_plus_axis = "+0"
input_l_x_minus_axis = "-0"
input_l_y_plus_axis = "+1"
Expand All @@ -38,24 +26,24 @@ input_r_x_plus_axis = "+2"
input_r_x_minus_axis = "-2"
input_r_y_plus_axis = "+3"
input_r_y_minus_axis = "-3"

input_a_btn_label = "A"
input_menu_toggle_btn = "5"
input_screenshot_btn = "15"
input_b_btn_label = "B"
input_x_btn_label = "X"
input_y_btn_label = "Y"
input_select_btn_label = "Minus"
input_start_btn_label = "Plus"
input_l_btn_label = "L"
input_r_btn_label = "R"
input_l2_axis_label = "ZL"
input_r2_axis_label = "ZR"
input_l3_btn_label = "Left Stick Press"
input_r3_btn_label = "Right Stick Press"
input_menu_toggle_btn_label = "Home"
input_up_btn_label = "D-Pad Up"
input_down_btn_label = "D-Pad Down"
input_left_btn_label = "D-Pad Left"
input_right_btn_label = "D-Pad Right"
input_a_btn_label = "A"
input_x_btn_label = "X"
input_l_btn_label = "L"
input_r_btn_label = "R"
input_l2_btn_label = "ZL"
input_r2_btn_label = "ZR"
input_l3_btn_label = "Left Stick Press"
input_r3_btn_label = "Right Stick Press"
input_l_x_plus_axis_label = "Left Analog X+ (Right)"
input_l_x_minus_axis_label = "Left Analog X- (Left)"
input_l_y_plus_axis_label = "Left Analog Y+ (Down)"
Expand All @@ -64,3 +52,5 @@ input_r_x_plus_axis_label = "Right Analog X+ (Right)"
input_r_x_minus_axis_label = "Right Analog X- (Left)"
input_r_y_plus_axis_label = "Right Analog Y+ (Down)"
input_r_y_minus_axis_label = "Right Analog Y- (Up)"
input_menu_toggle_btn_label = "Home"
input_screenshot_btn_label = "Screenshot"
Loading