[READY] udev: Update and rename Nintendo Co., Ltd. Pro Controller (old).cfg to Pro Controller (non-HID) (default-off).cfg
#1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Controller (default-off).cfg The individual responsible for uploading the file inadvertently swapped the non-HID autoconfig file with the HID autoconfig file. You can access the non-HID file [here](libretro@3abfcb2) and the HID file [here](libretro@3abfcb2). To address this issue, I: * Removed "(old)" from the non-HID file and added "(default-off)" to the HID file to align with our updated naming convention. * Swapped their autoconfig data. However, he was correct about one detail. He included `input_device = "Pro Controller"` (Bluetooth identifier name), which I mistakenly later changed to `input_device = "Nintendo Co., Ltd. Pro Controller"` (USB identifier name) ([source](libretro@98b1591)). The non-HID driver does not support USB connection for this controller, only Bluetooth. I made this change because I believed the udev controller driver identified the controller using `input_vendor_id` / `input_product_id`, as generated by "Save Controller Profile" in RetroArch, but later discovered that udev relies on `input_device`, which led me to file a bug report. Consequently, I edited this file: * I removed the commented variables `input_product_id` and `input_vendor_id` which fail to disable this controller. * Commented `input_device = Pro Controller` to disable this controller to leave file name space for `Pro Controller.cfg` (HID) since Linux 6.8.0 (Ubuntu 24.04) also identifies this controller as "Pro Controller". I filed this issue just a few days ago: * [GitHub Issue](libretro/RetroArch#16904) Additionally, I removed the comments as a standard procedure. "non-HID" is included in `input_device_display_name`.
This was referenced Aug 26, 2024
davidhedlund
changed the title
Nintendo Co., Ltd. Pro Controller (old).cfg to Pro Controller (default-off).cfgNintendo Co., Ltd. Pro Controller (old).cfg to Pro Controller (default-off).cfg
davidhedlund
changed the title
Nintendo Co., Ltd. Pro Controller (old).cfg to Pro Controller (default-off).cfgNintendo Co., Ltd. Pro Controller (old).cfg to Pro Controller (default-off).cfg
davidhedlund
changed the title
Nintendo Co., Ltd. Pro Controller (old).cfg to Pro Controller (default-off).cfgNintendo Co., Ltd. Pro Controller (old).cfg to Pro Controller (default-off).cfg
… Pro Controller (default-off).cfg corrected the name
input_screenshot_btn = "13"
remove input_screenshot_btn = "13" -- the screenshot button does not work
RobLoach
requested changes
Sep 28, 2024
…witch Pro Controller (non-HID) (default-off).cfg added "(non-HID) " to the filename
davidhedlund
changed the title
Nintendo Co., Ltd. Pro Controller (old).cfg to Pro Controller (default-off).cfgNintendo Co., Ltd. Pro Controller (old).cfg to Pro Controller (non-HID) (default-off).cfg
First and foremost, most pull requests include numerous updates that I have detailed in the comments. This makes it challenging to review all the updates if they are merged. In the future, I'll aim to submit individual pull requests when they are less complex. Additionally merging the PRs might reduce their scalability:
Reaching this point has been quite time-consuming, so I kindly ask you to accept the current PR structure. I need to practice Git. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
input_device_display_name.input_product_idandinput_vendor_id, andinput_deviceto disable this controller, to avoid conflicts withNintendo Switch Pro Controller.cfg(HID).