Downgrade major version to 29 #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchen07
reviewed
Aug 26, 2023
Bumping the major version to 30 is technically the correct thing to do from a semver perspective when a public API is removed. However, it also has a huge impact that outweighs the API breakage in terms of propogating the change to all consumers. We feel like this tradeoff is acceptable.
zackthehuman
force-pushed
the
zmulgrew/downgrade-major
branch
from
cfef163
to
1559a75
Compare
ZoabKapoor
approved these changes
Aug 26, 2023
ZoabKapoor
approved these changes
Aug 26, 2023
There was a problem hiding this comment.
Looks good, thanks for doing this! As mentioned in the release notes, this is definitely not SemVer compatible as it's a version decrement, but it seems like the safest way to undo the 30.0.0 change which was made in error as we don't want to have to maintain many restli major versions side-by-side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping the major version to 30 is technically the correct thing to do from a semver perspective when a public API is removed. However, it also has a huge impact that outweighs the API breakage in terms of propogating the change to all consumers. We feel like this tradeoff is acceptable.