Remove some unnecessary preferences, handle intro adventures, desert priority/delay, add small path task order & some other misc changes. #1377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ended up being larger than I would like and I still have more things to fix but it will do for now.
Removing preferences:
auto_skipNEPOverride
- unnecessary. There was one user years ago who complained they didn't want to have the script use NEP because they wanted to do it manually or in aftercore or something. No one will ever need this.auto_dickstab
- this is a remnant from when Cheesecookie used cc_ascend as his personal looping script (back when you could ascend as many times in a day as you wish, check his ascension history). There are actual looping scripts which exist now which do a much better job of optimising resource use with regards to meat gains but that isn't the remit of autoscend. It's also an offensive term which we shouldn't encourage the use of even if it was originated by KoL development team members.auto_getDinseyGarbageMoney
- unnecessary. We don't adventure at Barf Mountain in unrestricted without intentionally choosing to do so and again this isn't a looping script.auto_hatchRagamuffinImp
- does nothing now. code was removed by me recently & this was overlooked.auto_saveMagicalSausage
- unnecessary. Another "one user complained years ago so we added a preference to placate them" that no one will ever need.auto_useWishes
- similar to auto_dickstab this is a remnant of cc_ascend.auto_doNotUseCMC
- doesn't do anything other than stop us pulling items from the CMC. Again this isn't a looping script and the new workshed handling will still install it with this enabled it just won't ever do anything with it.Intro Adventures
Added handling for some of the Intro adventures for challenge paths. This code should be easily extended to things I haven't added (I gave up around DG which is when cc_ascend was forked to sl_ascend) and to add new paths when released.
The Arid, Extra-Dry Desert
I added 2 things here. The function will be called very early when you have Ultrahydrated as we can acquire it from combats by having BoFa. I also added an early exit so that if you will be able to get the survival knife on day 2 (and don't already have Ultrahydrated) we delay doing the quest on day 1.
Task Order
I added a copy of the default.dat as the Small task order. They're identical right now but I intend to update the Small one as the default is very outdated & relatively unchanged from cc_ascend.
Misc
initializeSettings()
no longer runs when you open the relay page in aftercore. Means prefs don't get reset for no reason any more just because you went to check something in the relay.How Has This Been Tested?
Ran multiple Normal Small runs with different classes with these changes. No issues related to any of these changes.
Checklist: