Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unnecessary preferences, handle intro adventures, desert priority/delay, add small path task order & some other misc changes. #1377

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

Malibu-Stacey
Copy link
Member

@Malibu-Stacey Malibu-Stacey commented Oct 20, 2023

Description

This ended up being larger than I would like and I still have more things to fix but it will do for now.

Removing preferences:

  • auto_skipNEPOverride - unnecessary. There was one user years ago who complained they didn't want to have the script use NEP because they wanted to do it manually or in aftercore or something. No one will ever need this.
  • auto_dickstab - this is a remnant from when Cheesecookie used cc_ascend as his personal looping script (back when you could ascend as many times in a day as you wish, check his ascension history). There are actual looping scripts which exist now which do a much better job of optimising resource use with regards to meat gains but that isn't the remit of autoscend. It's also an offensive term which we shouldn't encourage the use of even if it was originated by KoL development team members.
  • auto_getDinseyGarbageMoney - unnecessary. We don't adventure at Barf Mountain in unrestricted without intentionally choosing to do so and again this isn't a looping script.
  • auto_hatchRagamuffinImp - does nothing now. code was removed by me recently & this was overlooked.
  • auto_saveMagicalSausage - unnecessary. Another "one user complained years ago so we added a preference to placate them" that no one will ever need.
  • auto_useWishes - similar to auto_dickstab this is a remnant of cc_ascend.
  • auto_doNotUseCMC - doesn't do anything other than stop us pulling items from the CMC. Again this isn't a looping script and the new workshed handling will still install it with this enabled it just won't ever do anything with it.

Intro Adventures
Added handling for some of the Intro adventures for challenge paths. This code should be easily extended to things I haven't added (I gave up around DG which is when cc_ascend was forked to sl_ascend) and to add new paths when released.

The Arid, Extra-Dry Desert
I added 2 things here. The function will be called very early when you have Ultrahydrated as we can acquire it from combats by having BoFa. I also added an early exit so that if you will be able to get the survival knife on day 2 (and don't already have Ultrahydrated) we delay doing the quest on day 1.

Task Order
I added a copy of the default.dat as the Small task order. They're identical right now but I intend to update the Small one as the default is very outdated & relatively unchanged from cc_ascend.

Misc

  • Pull a Smut Orc Keepsake box and use it early when we have the trainset. Helps get the CMC in sooner so we can get day 1 Breathitins.
  • initializeSettings() no longer runs when you open the relay page in aftercore. Means prefs don't get reset for no reason any more just because you went to check something in the relay.
  • Don't equip the combat lovers locket when going to the Noob Cave as we never actually go to the Noob Cave so it is perpetually trying to locket a crate.
  • deleted some unused functions in the elemental planes file.
  • Summon & backup a HitS monster for faster Star Key acquisition. This can be expanded to use Monster Habitats/Be Gregarious when we start adding BoFa support.

How Has This Been Tested?

Ran multiple Normal Small runs with different classes with these changes. No issues related to any of these changes.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have based my pull request against the main branch or have a good reason not to.

@Malibu-Stacey Malibu-Stacey requested review from a team October 20, 2023 23:30
@Malibu-Stacey Malibu-Stacey self-assigned this Oct 20, 2023
@Malibu-Stacey Malibu-Stacey changed the title Remove some unnecessary preferences, handle intro adventures, desert priority and delay, add small task order & some other misc changes. Remove some unnecessary preferences, handle intro adventures, desert priority/delay, add small path task order & some other misc changes. Oct 20, 2023
Copy link
Member

@Alium58 Alium58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

RELEASE/data/autoscend_task_order.txt Show resolved Hide resolved
RELEASE/scripts/autoscend.ash Outdated Show resolved Hide resolved
RELEASE/scripts/autoscend/auto_bedtime.ash Show resolved Hide resolved
BUILD/settings/any.dat Show resolved Hide resolved
RELEASE/scripts/autoscend/quests/level_11.ash Outdated Show resolved Hide resolved
RELEASE/scripts/autoscend/quests/level_13.ash Show resolved Hide resolved
@Malibu-Stacey Malibu-Stacey merged commit cb37501 into main Oct 26, 2023
2 checks passed
@Malibu-Stacey Malibu-Stacey deleted the brimstone branch October 26, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants