feat: add vitepress folder icon
#2653
Conversation
Fixes #2587 Added VitePress folder icon. * Add a new entry for `.vitepress` in `folderIcons` array in `src/core/icons/folderIcons.ts`. * Add `folder-vitepress.svg` and `folder-vitepress-open.svg` to the `icons` directory. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/material-extensions/vscode-material-icon-theme/issues/2587?shareId=XXXX-XXXX-XXXX-XXXX).
PreviewThank you for creating a pull request. This preview shows you how your icons will look on the different themes: Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link. You can find more information on how to contribute in the contribution guidelines. |
There was a problem hiding this comment.
The icons are not fitting to the other folder icons because of the 3 different colors. Typically all of the folder icons in this extension only have two colors: one for the folder itself and another one for the motive in the foreground. This folder icon here adds an additional layer by giving the lightning motive a separate background. I was wondering if there's a possibility to redesign this folder icon in such a way that we only have the background and one foreground element.
For instance we could use the lightning symbol without that rectangular background layer. Just the plain lightning on the folder icon.
There was a problem hiding this comment.
Then it will look like Vite folder, not Vitepress
There was a problem hiding this comment.
True. But I'd rather not have a specific folder icon than bring some icons which don't fit into the extension. Let's keep it open for discussion until we find a better solution which will be more suitable.
There was a problem hiding this comment.
yeah, we should at least change the color a little bit. When I go to their website, then I don't see that teal color, but rather a purple:
Maybe you can change the color of the folder icon to #7C4DFF.
There was a problem hiding this comment.
yeah, we should at least change the color a little bit. When I go to their website, then I don't see that teal color, but rather a purple:
Maybe you can change the color of the folder icon to #7C4DFF.
I will do it tomorrow
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Signed-off-by: Okinea Dev <81070564+okineadev@users.noreply.github.com>
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.
|
I was wondering if it's better when we align the lightning with the grid:
ah, and this one:
We could also elaborate how it would look like if we give the lightning a yellow color. I know it's not following our rules, but maybe it looks a little better, not sure. |
PKief
force-pushed
the
main
branch
2 times, most recently
from
7918c28
to
7cb05b2
Compare
Closes #2587
Added VitePress folder icon.
.vitepressinfolderIconsarray insrc/core/icons/folderIcons.ts.folder-vitepress.svgandfolder-vitepress-open.svgto theiconsdirectory.For more details, open the Copilot Workspace session.