Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add vitepress folder icon #2653

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: add vitepress folder icon #2653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
018a14e
feat: add `vitepress` folder icon
okineadev Oct 31, 2024
b70cc48
Merge branch 'main' into okineadev/add-vitepress-icon
okineadev Oct 31, 2024
6fec42e
fix: fix vitepress folder icon
okineadev Nov 4, 2024
e443a2e
Merge branch 'main' into okineadev/add-vitepress-icon
okineadev Nov 4, 2024
800f89e
Merge branch 'main' into okineadev/add-vitepress-icon
PKief Nov 4, 2024
e47dde0
Merge branch 'main' into okineadev/add-vitepress-icon
PKief Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions icons/folder-vitepress-open.svg
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons are not fitting to the other folder icons because of the 3 different colors. Typically all of the folder icons in this extension only have two colors: one for the folder itself and another one for the motive in the foreground. This folder icon here adds an additional layer by giving the lightning motive a separate background. I was wondering if there's a possibility to redesign this folder icon in such a way that we only have the background and one foreground element.

For instance we could use the lightning symbol without that rectangular background layer. Just the plain lightning on the folder icon.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it will look like Vite folder, not Vitepress

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. But I'd rather not have a specific folder icon than bring some icons which don't fit into the extension. Let's keep it open for discussion until we find a better solution which will be more suitable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preview

Looks dumb but ok

Copy link
Member

@PKief PKief Nov 5, 2024 •
edited by okineadev
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we should at least change the color a little bit. When I go to their website, then I don't see that teal color, but rather a purple:

image

Maybe you can change the color of the folder icon to #7C4DFF.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we should at least change the color a little bit. When I go to their website, then I don't see that teal color, but rather a purple:

image

Maybe you can change the color of the folder icon to #7C4DFF.

I will do it tomorrow

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions icons/folder-vitepress.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 5 additions & 1 deletion src/core/icons/folderIcons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1010,7 +1010,11 @@ export const folderIcons: FolderTheme[] = [
{ name: 'folder-lefthook', folderNames: ['lefthook', 'lefthook-local'] },
{
name: 'folder-powershell',
folderNames: ['powershell', 'ps', 'ps1'],
folderNames: ["powershell", "ps", "ps1"]
},
{
name: 'folder-vitepress',
folderNames: ['.vitepress'],
},
{
name: 'folder-luau',
Expand Down