Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow redacted events as latest event #2512

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Sep 5, 2023

Maybe a fix for element-hq/element-x-ios#1441, I'm really not sure 😅

We've always wanted to include redacted events AFAICT, it was likely just a misunderstanding that we might want to exclude them.

… of TimelineItemContent::from_suitable_latest_event_content.
It had no branches that returned None.
@jplatte jplatte requested a review from a team as a code owner September 5, 2023 15:45
@jplatte jplatte requested review from bnjbvr and removed request for a team and bnjbvr September 5, 2023 15:45
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 92.85% and project coverage change: -0.02% ⚠️

Comparison is base (cc469f6) 77.45% compared to head (eeeaea9) 77.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2512      +/-   ##
==========================================
- Coverage   77.45%   77.43%   -0.02%     
==========================================
  Files         178      178              
  Lines       19208    19210       +2     
==========================================
- Hits        14878    14876       -2     
- Misses       4330     4334       +4     
Files Changed Coverage Δ
...s/matrix-sdk-ui/src/timeline/event_item/content.rs 54.80% <91.66%> (+0.68%) ⬆️
crates/matrix-sdk-base/src/latest_event.rs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and fwiw I disagree with SonarCloud that this reduces coverage ;-)

@jplatte jplatte merged commit 2787d05 into main Sep 6, 2023
36 checks passed
@jplatte jplatte deleted the jplatte/latest-event-redacted branch September 6, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants