Adds a HTTP controller implementation #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Controllers interfacing over HTTP will not be checking in or publishing liveness updates
The HTTP based controller does not register for liveness checkins
A few additional changes for fetching the Condition and Task objects
DoctorVin
reviewed
Jul 31, 2024
| } | ||
|
|
||
| // state active | ||
| if cond.State == condition.Active { |
There was a problem hiding this comment.
I feel like we could smooth this interaction between Orchestrator and an HTTP client. Maybe condense this into a single interaction? I have some thoughts about implementing it, maybe I can get some time to help out.
this could be used by controllers regardless of how they are deployed (inband/oob)
DoctorVin
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This controller interfaces with the Orchestrator API to carry out Condition work and publish updates.