mitosheet: handle unset colors in conditional formatting #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aarondr77
commented
Mar 14, 2024
| @@ -80,6 +80,7 @@ const SetDataframeFormatTaskpane = (props: SetDataframeFormatTaskpaneProps): JSX | |||
| } | |||
|
|
|||
| const updateDataframeFormatParams = (newParams: RecursivePartial<DataframeFormat>): void => { | |||
| console.log(newParams) | |||
naterush
reviewed
Mar 18, 2024
Comment on lines
128
to
139
| // If the user does not change the color or background color, we want to treat them as undefined | ||
| // so it doesn't change the data in the Mito Spreadsheet or the created Styler or Excel file | ||
| newParams.conditional_formats = newParams?.conditional_formats?.map(conditionalFormat => { | ||
| const newConditionalFormat = {...conditionalFormat}; | ||
| if (newConditionalFormat.color === "var(--mito-text)") { | ||
| newConditionalFormat.color = undefined; | ||
| } | ||
| if (newConditionalFormat.backgroundColor === "var(--mito-background-off)") { | ||
| newConditionalFormat.backgroundColor = undefined; | ||
| } | ||
| return newConditionalFormat; | ||
| }) |
There was a problem hiding this comment.
This is a weird way to do this. Why not just default them to undefined when we create them?
|
This actually isn't a solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1274
Testing
Please provide a list of the ways you can "access" or use the functionality. Please try and be exhaustive here, and make sure that you test everything you list.
Documentation
Note if any new documentation needs to addressed or reviewed.