Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mitosheet: handle unset colors in conditional formatting #1279

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,19 @@ const ConditionalFormattingTaskpane = (props: ConditionalFormattingTaskpaneProps
)

const updateDataframeFormatParams = (newParams: RecursivePartial<DataframeFormat>): void => {
// If the user does not change the color or background color, we want to treat them as undefined
// so it doesn't change the data in the Mito Spreadsheet or the created Styler or Excel file
newParams.conditional_formats = newParams?.conditional_formats?.map(conditionalFormat => {
const newConditionalFormat = {...conditionalFormat};
if (newConditionalFormat.color === "var(--mito-text)") {
newConditionalFormat.color = undefined;
}
if (newConditionalFormat.backgroundColor === "var(--mito-background-off)") {
newConditionalFormat.backgroundColor = undefined;
}
return newConditionalFormat;
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a weird way to do this. Why not just default them to undefined when we create them?


setParams(prevParams => {
return updateObjectWithPartialObject(prevParams, {df_format: newParams})
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ const SetDataframeFormatTaskpane = (props: SetDataframeFormatTaskpaneProps): JSX
}

const updateDataframeFormatParams = (newParams: RecursivePartial<DataframeFormat>): void => {
console.log(newParams)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

setParams(prevParams => {
return updateObjectWithPartialObject(prevParams, {df_format: newParams})
})
Expand Down
35 changes: 35 additions & 0 deletions tests/streamlit_ui_tests/taskpanes/conditional_formatting.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import { expect, test } from '@playwright/test';
import { awaitResponse, getMitoFrameWithTestCSV } from '../utils';

test.describe('Conditional Formatting', () => {
test('Leave conditional format color and backgroud_color unset', async ({ page }) => {
const mito = await getMitoFrameWithTestCSV(page);
await mito.getByRole('button', { name: 'Conditional Formatting', exact: true }).click();
awaitResponse(page)
await mito.getByRole('button', { name: 'Add Conditional Formatting Rule', exact: true }).click();
awaitResponse(page)
await mito.getByText('Is not empty').click();
awaitResponse(page)
await mito.getByText('Toggle All').click();
awaitResponse(page)

// Click on the Export
await mito.locator('.mito-toolbar-button', { hasText: 'Export'}).click();
await mito.locator('.mito-dropdown-item', { hasText: 'Download File when Executing Code'}).click();
await awaitResponse(page);
awaitResponse(page)
await mito.getByText('CSV').click();
awaitResponse(page)
await mito.getByText('Excel').click();
awaitResponse(page)

await mito.getByText('Generate Export Code').click();
awaitResponse(page)

// Make sure the code doesn't have mito css variables in it and there should be no styler since
// no style is actually applied!
await expect(mito.getByText('var(--mito-text)')).not.toBeVisible();
await expect(mito.getByText('var(--mito-background-off')).not.toBeVisible();
await expect(mito.getByText('styler')).not.toBeVisible();
});
})
Loading