-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mitosheet: handle unset colors in conditional formatting #1279
Closed
Closed
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -80,6 +80,7 @@ const SetDataframeFormatTaskpane = (props: SetDataframeFormatTaskpaneProps): JSX | |
} | ||
|
||
const updateDataframeFormatParams = (newParams: RecursivePartial<DataframeFormat>): void => { | ||
console.log(newParams) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove |
||
setParams(prevParams => { | ||
return updateObjectWithPartialObject(prevParams, {df_format: newParams}) | ||
}) | ||
|
35 changes: 35 additions & 0 deletions
35
tests/streamlit_ui_tests/taskpanes/conditional_formatting.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
import { expect, test } from '@playwright/test'; | ||
import { awaitResponse, getMitoFrameWithTestCSV } from '../utils'; | ||
|
||
test.describe('Conditional Formatting', () => { | ||
test('Leave conditional format color and backgroud_color unset', async ({ page }) => { | ||
const mito = await getMitoFrameWithTestCSV(page); | ||
await mito.getByRole('button', { name: 'Conditional Formatting', exact: true }).click(); | ||
awaitResponse(page) | ||
await mito.getByRole('button', { name: 'Add Conditional Formatting Rule', exact: true }).click(); | ||
awaitResponse(page) | ||
await mito.getByText('Is not empty').click(); | ||
awaitResponse(page) | ||
await mito.getByText('Toggle All').click(); | ||
awaitResponse(page) | ||
|
||
// Click on the Export | ||
await mito.locator('.mito-toolbar-button', { hasText: 'Export'}).click(); | ||
await mito.locator('.mito-dropdown-item', { hasText: 'Download File when Executing Code'}).click(); | ||
await awaitResponse(page); | ||
awaitResponse(page) | ||
await mito.getByText('CSV').click(); | ||
awaitResponse(page) | ||
await mito.getByText('Excel').click(); | ||
awaitResponse(page) | ||
|
||
await mito.getByText('Generate Export Code').click(); | ||
awaitResponse(page) | ||
|
||
// Make sure the code doesn't have mito css variables in it and there should be no styler since | ||
// no style is actually applied! | ||
await expect(mito.getByText('var(--mito-text)')).not.toBeVisible(); | ||
await expect(mito.getByText('var(--mito-background-off')).not.toBeVisible(); | ||
await expect(mito.getByText('styler')).not.toBeVisible(); | ||
}); | ||
}) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a weird way to do this. Why not just default them to undefined when we create them?