-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added support for localization #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Just some minor adjustments to documentation are needed.
Also, do not forget to update the CHANGELOG.md
file, like:
# Next
- feat: add support for slide deck localization
@mkobuolys Thank you for reviewing! I've fixed both of them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Today I will try to add a control to change the slide deck's language at run-time, update the docs, and example. It will be released with v0.12.0 ASAP.
@mkobuolys Big appreciation for merging! I'll use this when released as I have one slide deck I want to build with this feature (not in a hurry). |
Screen.Recording.2024-03-03.at.23.56.08.movIt's almost there, probably coming out tomorrow. Let's keep it a secret for now 🤫 |
The control looks so cool! |
Status
READY
Description
Added support for localization of slides by bypassing
MaterialApp
's parameters for localization.This would be useful for those (like me) who originally made a slide in a non-English language, Japanese for instance, and want to share it globally with the same URL.
Type of Change
References
https://docs.flutter.dev/ui/accessibility-and-internationalization/internationalization