bug-1901997: handle invalid BuildID for redacted crash reports #6777
+92
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to adjust a crash report for testing a specific processing scenario.
If the user viewing the crash report does not have protected data access and the crash report has a crash annotation value that doesn't match our schema, then the redaction process can fail. In this scenario, Crash Stats can't recover and redact the document properly. In bug 1901997, we were seeing this scenario when BuildID=null. Because crash annotation data comes from the crash reporter which might be running on a machine that has bad hardware, this scenario can happen with other fields. These changes handle that scenario and shows a page indicating the crash report is malformed and providing a link the user can use to report the malformed crash report.
relud
approved these changes
Oct 31, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user viewing the crash report does not have protected data access and the crash report has a crash annotation value that doesn't match our schema, then the redaction process can fail. In this scenario, Crash Stats can't recover and redact the document properly.
In bug 1901997, we were seeing this scenario when
BuildID=null. Because crash annotation data comes from the crash reporter which might be running on a machine that has bad hardware, this scenario can happen with other fields.These changes handle that scenario and shows a page indicating the crash report is malformed and providing a link the user can use to report the malformed crash report.
While doing this, I adjusted
bin/process_crashes.shso it allows you to pause it before it uploads data to the bucket. This makes it easier to adjust crash reports to test specific scenarios.