Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug-1901997: handle invalid BuildID for redacted crash reports #6777

Merged
merged 2 commits into from
Oct 31, 2024
Merged

bug-1901997: handle invalid BuildID for redacted crash reports #6777

merged 2 commits into from
Oct 31, 2024
+92 −3

Commits on Oct 31, 2024

  1. Add support for --pause to process_crashes.sh 

    This makes it possible to adjust a crash report for testing a specific
processing scenario.
    @willkg
    willkg committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    159928b View commit details
    Browse the repository at this point in the history

  2. bug-1901997: handle invalid BuildID for redacted crash reports 

    If the user viewing the crash report does not have protected data access
and the crash report has a crash annotation value that doesn't match our
schema, then the redaction process can fail. In this scenario, Crash
Stats can't recover and redact the document properly.

In bug 1901997, we were seeing this scenario when BuildID=null. Because
crash annotation data comes from the crash reporter which might be
running on a machine that has bad hardware, this scenario can happen
with other fields.

These changes handle that scenario and shows a page indicating the crash
report is malformed and providing a link the user can use to report the
malformed crash report.
    @willkg
    willkg committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    61bb024 View commit details
    Browse the repository at this point in the history