-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Add dimensions to Workspace module #3986
BUGFIX: Add dimensions to Workspace module #3986
Conversation
Neos.Neos/Classes/Controller/Module/Management/WorkspacesController.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works fine, and we have just nitpicks in the code.
Neos.Neos/Classes/Controller/Module/Management/WorkspacesController.php
Outdated
Show resolved
Hide resolved
Would be nice if someone can have a second look @kdambekalns @mhsdesign @kitsunet 🙏 |
No one else available for a review @kitsunet @kdambekalns or @Sebobo |
Neos.Neos/Classes/Controller/Module/Management/WorkspacesController.php
Outdated
Show resolved
Hide resolved
I have actually done something like this before in a customer project, I have to compare and remember the edge cases I encountered, so I need a moment, I am pretty sure there were some problems with this (eg. if you create a document in a dimension that also has another dimension as fallback, and then underneath two documents for both dimensions, you shouldn't publish the fallbck sub document as it would miss a parent in that case, stuff like that. this case becomes even worse for content and fallbacks). |
Certainly, @kitsunet ! It's great to hear that you have experience with a similar scenario in a customer project. Your insights into potential issues are valuable. To proceed, could you please provide more details about the specific problems you encountered during that project? Understanding the edge cases and challenges you faced will help us address those issues effectively and come up with solutions to ensure a smooth implementation. Please don't hesitate to share any specific scenarios, complications, or concerns you remember encountering. This will enable us to discuss and brainstorm potential solutions to tackle those issues and ensure a successful outcome for your current project. |
e7beadc
to
1b96bef
Compare
Rebased changes so that the PR is mergeable until we find a solution for the discussion :) |
How do we want to proceed here? This will definitely be not easy to upmerge so we need to reimplement this for neos 9 as well. |
In the Neos 9.0 weekly we talked today about the PR and @kitsunet mentioned that he is fine with merging it. |
resolves: #3470
This adds Dimension handling to the current workspaces module.
Currently the Module only displays changes in different languages as one change. This is because the node path is the same in different languages after they are copied.
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions