-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: add dimensionshash migration to postgres #4429
BUGFIX: add dimensionshash migration to postgres #4429
Conversation
Hello, Thanks for your contribution! Is this bugfix related too 8.3? otherwise this should go in the 7.3 branch. |
I am currently developing with 8.3 but I am open to merge this into 7.3 |
Hm. I believe something went wrong during the rebase. Can you fix this? Otherwise, you can create a new branch based on 7.3 and open a new pull request :) |
6b27c57
to
bd60a11
Compare
Adjusted the PR and now it is based on Neos 7.3. |
I was wrong and @andrehoffmann30 added the hash in Neos 8.3, and we just forgot the Postgres Migration. So will adjust that to 8.3 again. |
Looks good to me! But we need to change it back to 8.3, as this was introduced for MySQL in 8.3 too. |
bd60a11
to
8df08fa
Compare
We discussed that PR in our CR Weekly and agreed on merging that change. In Neos 9.0 the EventLog has been removed. |
Thanks for Your contribution @Jonathan2022Bausch 🥇💙 |
Your first contribution has been released now 🥳 |
Regression #3279
We need to generate add dimensions hash to node event model in order to be able to save new nodes as we do in MySQL: Neos.Neos/Migrations/Mysql/Version20210125134503.php
Upgrade instructions
Run ./flow doctrine:migrate
Review instructions
You want to make sure that the dimensions table has valid values. If not you might want to add a custom migration like this one:
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions