Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SparseZoo V2 Bug Fixes #1719

Merged
merged 14 commits into from
Sep 15, 2023
Merged

SparseZoo V2 Bug Fixes #1719

merged 14 commits into from
Sep 15, 2023

Conversation

Satrat
Copy link

@Satrat Satrat commented Sep 8, 2023 •
edited
Loading

Fixing issues caused by the upgrade to SparseZoo V2:

  1. Model class stores recipes in a list, updated optim/helpers.py to reflect this change This was handled instead by updating SparseZoo to restore the default functionality: neuralmagic/sparsezoo@f2cf607
  2. Changed multiple filename searches to use - instead of _ to reflect change in sparsezoo
  3. Removed deprecated test case that searches for original.md recipe (these have been renamed to recipe.md). Replaced with a test that searches for a non-default recipe name

@Satrat Satrat marked this pull request as ready for review September 11, 2023 17:08
bfineran
bfineran previously approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@bfineran bfineran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marking OK to land, however we need to get recipes.default back to supported so that ?recipe_type in stubs will work reliably

@Satrat Satrat mentioned this pull request Sep 14, 2023
Merged
@Satrat Satrat merged commit e5faef5 into main Sep 15, 2023
10 of 11 checks passed
@Satrat Satrat deleted the sa/sparsezoo_v2_compat branch September 15, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul-tuli rahul-tuli rahul-tuli approved these changes

@horheynm horheynm horheynm approved these changes

@dbogunowicz dbogunowicz Awaiting requested review from dbogunowicz

@dsikka dsikka Awaiting requested review from dsikka

@bfineran bfineran Awaiting requested review from bfineran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Satrat @bfineran @rahul-tuli @horheynm