Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include frequencies for N450 build #42

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Include frequencies for N450 build #42

merged 2 commits into from
Jul 3, 2024

Conversation

trvrb
Copy link
Member

@trvrb trvrb commented Jun 28, 2024

This commit produces tip-frequencies JSON files for both N450 and genome analyses, but only displays frequencies panel for N450.

Start date of 2000 and end date of –6 months were chosen based on data availability. I increased bandwidth by about 2.5x to account for data quantity relative to temporal spread (compared to the 2y flu-like defaults).

Generally, I think it's quite useful to display frequencies once we have:

  1. A decent amount of sampling (with 3000 sequences the N450 build is good for this)
  2. A suitable granularity clade to display (MeV genotype works for this)

You can see output of running this PR here: https://nextstrain.org/staging/measles/frequencies/N450

Screenshot 2024-06-28 at 3 08 36 PM

There are some nice interactions, like seeing how restricted genotypes are in Africa vs Asia.

I've tagged @joverlee521 here as reviewer as well because I wasn't sure how frequencies should fit into the https://github.com/nextstrain/pathogen-repo-guide. I chose to add the rule to annotate_phylogeny.smk, which seems most suitable, but it's not really annotating the tree and could be it's own frequencies.smk file. Also, I chose to output to results/tip_frequencies.json and then copy this file to auspice/ under export.smk, but this copying could be thought of as extraneous.

This commit produces tip-frequencies JSON files for both N450 and genome analyses, but only displays frequencies panel for N450.

Start date of 2000 and end date of –6 months were chosen based on data availability. I increased bandwidth by about 2.5x to account for data quantity relative to temporal spread (compared to the 2y flu-like defaults).
@joverlee521
Copy link
Contributor

I've tagged @joverlee521 here as reviewer as well because I wasn't sure how frequencies should fit into the https://github.com/nextstrain/pathogen-repo-guide. I chose to add the rule to annotate_phylogeny.smk, which seems most suitable, but it's not really annotating the tree and could be it's own frequencies.smk file. Also, I chose to output to results/tip_frequencies.json and then copy this file to auspice/ under export.smk, but this copying could be thought of as extraneous.

The pathogen-repo-guide currently suggests augur frequencies as part of the export.smk with the thought that it can output directly to the exported auspice/ directory 😄

@trvrb
Copy link
Member Author

trvrb commented Jun 28, 2024

Ah! I missed this. This makes as much (if not more) sense to me as including it in annotate_phylogeny.smk. I'll update the PR.

Copy link
Contributor

@kimandrews kimandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, and it's really interesting to see the frequencies plot.

@trvrb trvrb merged commit 7f2c201 into main Jul 3, 2024
32 checks passed
@trvrb trvrb deleted the frequencies branch July 3, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants