chore: fix tachometer package swapping #439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it looks like I've been using Tachometer incorrectly for some time, and wasn't actually comparing PRs against the master branch. 😅
Due to google/tachometer#215 I need to make sure that any time we import the Picker/Database from a benchmark script, we do so from an npm package name that Tachometer can swap out. Luckily we can just create a dummy
file:.
dependency to do exactly this.Without this PR, the local and "remote" versions of Tachometer are both the same – just the local code!