Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix tachometer package swapping #439

Merged
merged 2 commits into from
Aug 16, 2024
Merged

chore: fix tachometer package swapping #439

merged 2 commits into from
Aug 16, 2024

Conversation

nolanlawson
Copy link
Owner

it looks like I've been using Tachometer incorrectly for some time, and wasn't actually comparing PRs against the master branch. 😅

Due to google/tachometer#215 I need to make sure that any time we import the Picker/Database from a benchmark script, we do so from an npm package name that Tachometer can swap out. Luckily we can just create a dummy file:. dependency to do exactly this.

Without this PR, the local and "remote" versions of Tachometer are both the same – just the local code!

Copy link

github-actions bot commented Aug 15, 2024

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-change-tab: unsure 🔍 -0% - +3% (-0.05ms - +1.07ms)
    this-change vs tip-of-tree
  • emoji-picker-element-database-interactions: unsure 🔍 -5% - +4% (-5.61ms - +4.80ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -6% - +1% (-3.06ms - +0.52ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -5% - +3% (-2.18ms - +1.55ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-change-tab
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
34.31ms - 35.16ms-unsure 🔍
-0% - +3%
-0.05ms - +1.07ms
tip-of-tree
tip-of-tree
33.86ms - 34.58msunsure 🔍
-3% - +0%
-1.07ms - +0.05ms
-
emoji-picker-element-database-interactions
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
102.81ms - 110.23ms-unsure 🔍
-5% - +4%
-5.61ms - +4.80ms
tip-of-tree
tip-of-tree
103.27ms - 110.58msunsure 🔍
-5% - +5%
-4.80ms - +5.61ms
-
emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
51.45ms - 53.61ms-unsure 🔍
-6% - +1%
-3.06ms - +0.52ms
tip-of-tree
tip-of-tree
52.38ms - 55.23msunsure 🔍
-1% - +6%
-0.52ms - +3.06ms
-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
45.26ms - 47.78ms-unsure 🔍
-5% - +3%
-2.18ms - +1.55ms
tip-of-tree
tip-of-tree
45.46ms - 48.20msunsure 🔍
-3% - +5%
-1.55ms - +2.18ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link

github-actions bot commented Aug 15, 2024

Size Change: 0 B

Total Size: 36.3 kB

ℹ️ View Unchanged
Filename Size
./bundle.js 36.3 kB

compressed-size-action

@nolanlawson nolanlawson merged commit 627e4f3 into master Aug 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant