Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework ritual initiation script for use on mainnet #297

Merged
merged 11 commits into from
Aug 9, 2024
Merged

Rework ritual initiation script for use on mainnet #297

merged 11 commits into from
Aug 9, 2024

Conversation

KPrasch
Copy link
Member

@KPrasch KPrasch commented Aug 2, 2024 •
edited
Loading

Type of PR:
Feature

Required reviews:
2

What this does:

  • Expands the ape-based ritual initiation script with:
    • porter node sampling
    • parameterized authority address
    • generic fee models/subscription types
    • handpicked nodes file (newline separated)
  • Formalizes click types and requirements use by the command.
  • Tested on mainnet with ritual 25 and 26.

Notes for reviewers:
Based over #298

@KPrasch KPrasch force-pushed the dkg-init branch 2 times, most recently from af333ec to 20f4ff8 Compare August 5, 2024 09:00
@KPrasch KPrasch changed the title [WIP] Updates ritual init script to immplement porter sampling Updates ritual init script to immplement porter sampling Aug 5, 2024
@KPrasch KPrasch changed the title Updates ritual init script to immplement porter sampling Updates ritual init script to implement porter sampling and fee models Aug 5, 2024
@KPrasch KPrasch changed the title Updates ritual init script to implement porter sampling and fee models Updates ritual init script to implement porter sampling, authority, and fee models Aug 5, 2024
@KPrasch KPrasch marked this pull request as ready for review August 5, 2024 09:41
derekpierre
derekpierre reviewed Aug 6, 2024
View reviewed changes
deployment/utils.py Outdated Show resolved Hide resolved
deployment/utils.py Outdated Show resolved Hide resolved
deployment/utils.py Outdated Show resolved Hide resolved
scripts/initiate_ritual.py Outdated Show resolved Hide resolved
scripts/initiate_ritual.py Outdated Show resolved Hide resolved
derekpierre
derekpierre reviewed Aug 6, 2024
View reviewed changes
scripts/initiate_ritual.py
authority = transactor.get_account().address
click.confirm(f"Using {authority} as the ritual authority. Continue?", abort=True)

if handpicked:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cool!

KPrasch added a commit to KPrasch/nucypher-contracts that referenced this pull request Aug 7, 2024
@KPrasch
Apply RFCs in PR nucypher#297
7a59a1f
@KPrasch KPrasch changed the title Updates ritual init script to implement porter sampling, authority, and fee models Rework ritual initiation script for use on mainnet Aug 7, 2024
derekpierre
derekpierre approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸 .

Just a minor nitpick suggestion.

scripts/initiate_ritual.py Outdated Show resolved Hide resolved
deployment/constants.py Outdated Show resolved Hide resolved
@KPrasch KPrasch mentioned this pull request Aug 7, 2024
Closed
manumonti
manumonti approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@manumonti manumonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, it looks great!

@KPrasch KPrasch merged commit 0dc8055 into nucypher:epic-subscription Aug 9, 2024
2 checks passed
derekpierre pushed a commit that referenced this pull request Aug 9, 2024
@KPrasch @derekpierre
Apply RFCs in PR #297
09e801f
derekpierre pushed a commit that referenced this pull request Aug 9, 2024
@KPrasch @derekpierre
respond to RFCs in PR #297
05b960e
@derekpierre derekpierre mentioned this pull request Aug 12, 2024
Merged
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theref theref theref approved these changes

@derekpierre derekpierre derekpierre approved these changes

@manumonti manumonti manumonti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KPrasch @theref @derekpierre @manumonti