-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Tapir contracts to be inline with mainnet #308
Conversation
theref
commented
Aug 16, 2024
•
edited
Loading
edited
- Deployment Scripts
- Configuration Files
- Deploy Contracts
- Registries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments/suggestions.
It could be good to use lynx/bqeth.yml
as an example for what tapir/bqeth.yml
should look like.
f4f0e34
to
8011f2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎸
63d7f68
to
8011f2f
Compare
…ct deployment. Co-authored-by: James Campbell <james.campbell@tanti.org.uk>
8011f2f
to
cad6aa3
Compare
@theref two outstanding items that we should do before merging this PR:
Consequently can you run:
to normalize the registry format back to what was produced by the deployment scripts. Then when committing the update to the format of the registry simply run:
So that the automated linter doesn't update the format. This is something that will be addressed in a separate issue/PR; filed #319 .
|
Fixed the formatting and verified the contract https://amoy.polygonscan.com/address/0xC3085b0feB8C348D0BD7fabF4299c93dc2aE11d7#writeProxyContract |