Add node version filtering for sampling #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andle this parameter
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #74 +/- ##
===============================================
+ Coverage 87.31% 90.54% +3.23%
===============================================
Files 18 18
Lines 867 899 +32
===============================================
+ Hits 757 814 +57
+ Misses 110 85 -25 ☔ View full report in Codecov by Sentry. |
13 tasks
vzotova
force-pushed
the
min-version
branch
2 times, most recently
from
284db31
to
4a958a9
Compare
…successful. Annotate what node dictionaries represent.
vzotova
requested review from
KPrasch,
arjunhassard,
cygnusv,
theref,
derekpierre and
manumonti
derekpierre
approved these changes
Aug 9, 2024
|
|
||
| def _validate(self, value): | ||
| try: | ||
| parse(value) |
| @@ -125,6 +126,18 @@ class GetUrsulas(BaseSchema): | |||
| ), | |||
| ) | |||
|
|
|||
| min_version = VersionString( | |||
There was a problem hiding this comment.
We need to update the README to add this optional parameter.
Filed #75 which can be addressed in a separate PR.
There was a problem hiding this comment.
Added small note in README for get_ursulas
KPrasch
approved these changes
Aug 12, 2024
cygnusv
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Issues fixed/closed:
Closes https://github.com/nucypher/sprints/issues/36.
Why it's needed:
Notes for reviewers: