Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node version filtering for sampling #74

Merged
merged 12 commits into from
Aug 12, 2024
Merged

Add node version filtering for sampling #74

merged 12 commits into from
Aug 12, 2024

Commits on Aug 2, 2024

  1. Adds Schema for accepting minimum version as parameter and draft to h… 

    …andle this parameter
    @vzotova
    vzotova committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    f35724e View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Use packaging.version.parse for comparing versions. 

    Split request into path and params.
    @derekpierre @vzotova
    derekpierre authored and vzotova committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    5a0c1b4 View commit details
    Browse the repository at this point in the history

  2. Mock function call that gets ursula version.

    @derekpierre @vzotova
    derekpierre authored and vzotova committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    9a4ca14 View commit details
    Browse the repository at this point in the history

  3. run linter, use Version.parse for schema

    @vzotova
    vzotova committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    ee9ee47 View commit details
    Browse the repository at this point in the history

  4. Move mock of getting ursula version to the porter fixture

    @vzotova
    vzotova committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    ef31aee View commit details
    Browse the repository at this point in the history

  5. Fix parsing versions after manual testing

    @vzotova
    vzotova committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    f735076 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Changing mocking in tests for RestMiddleware and testing versioning

    @vzotova
    vzotova committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    619ea94 View commit details
    Browse the repository at this point in the history

  2. Copy dict for safety.

    @derekpierre
    derekpierre committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    2c9a5e9 View commit details
    Browse the repository at this point in the history

  3. Use monkeypatch for WorkerPool._sleep override.

    @derekpierre
    derekpierre committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    1c22001 View commit details
    Browse the repository at this point in the history

  4. Use custom exception for Ursula having a version that is too old.

    @derekpierre
    derekpierre committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    bd537c6 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Fix bug where node doesn't have a bucket when we try to mark it as un… 

    …successful.

Annotate what node dictionaries represent.
    @derekpierre
    derekpierre committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    78f0d93 View commit details
    Browse the repository at this point in the history

  2. Added min_version parameter for /get_ursulas in README

    @vzotova
    vzotova committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    702334a View commit details
    Browse the repository at this point in the history