Issue #4: Add Github Actions to run tests #7
Conversation
.github/workflows/test.yml
Outdated
| echo OP_GOERLI_DEPLOYER_PK="${{ secrets.TEST_DEPLOYER_PK }}" >> .env | ||
| echo ARB_GOERLI_RPC="${{ secrets.ARB_GOERLI_RPC }}" >> .env | ||
| echo ARB_MAINNET_RPC="${{ secrets.ARB_MAINNET_RPC }}" >> .env | ||
| cat .env |
There was a problem hiding this comment.
maybe remove the cat, since we dont need to display the env
There was a problem hiding this comment.
I've removed the cat command and moved this entire "create .env" job into the env category that we had already. It runs successfully:
https://github.com/open-dollar/od-relayer/actions/runs/7213145447/job/19652349583
|
|
||
| concurrency: | ||
| group: ${{github.workflow}}-${{github.ref}} | ||
| cancel-in-progress: true | ||
|
|
||
| env: | ||
| FOUNDRY_PROFILE: ci |
There was a problem hiding this comment.
Can't we do the env stuff here rather than creating a file?
|
|
||
| concurrency: | ||
| group: ${{github.workflow}}-${{github.ref}} | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
Why cancel runs for other PRs?
There was a problem hiding this comment.
this section just makes sure that if someone is pushing several commits to the same branch/PR then it will cancel the one that's already in-progress and run just the latest one. I think it's useful if someone is developing on a specific PR for example and they push 3 commits in 2 minutes then it will make sure that only the latest job will be run to completion. do you think it's better to take it out?
Closes #4
Description
I changed the tests to run on each PR. I think the tests are running properly, there's just one test failing. Do you think this is a configuration issue or expected? Here's the latest test run:
https://github.com/open-dollar/od-relayer/actions/runs/7187980493/job/19576705177