Issue #4: Add Github Actions to run tests #7
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,10 @@ | ||
| name: test | ||
|
|
||
| on: [push] | ||
|
|
||
| concurrency: | ||
| group: ${{github.workflow}}-${{github.ref}} | ||
| cancel-in-progress: true | ||
|
|
||
| env: | ||
| FOUNDRY_PROFILE: ci | ||
|
There was a problem hiding this comment. Can't we do the env stuff here rather than creating a file? |
||
|
|
@@ -28,6 +32,17 @@ jobs: | |
| forge build --sizes | ||
| id: build | ||
|
|
||
| - name: Create env file | ||
| run: | | ||
| touch .env | ||
| echo OP_MAINNET_RPC="${{ secrets.OP_MAINNET_RPC }}" >> .env | ||
| echo OP_GOERLI_RPC="${{ secrets.OP_GOERLI_RPC }}" >> .env | ||
| echo OP_MAINNET_DEPLOYER_PK="${{ secrets.TEST_DEPLOYER_PK }}" >> .env | ||
| echo OP_GOERLI_DEPLOYER_PK="${{ secrets.TEST_DEPLOYER_PK }}" >> .env | ||
| echo ARB_GOERLI_RPC="${{ secrets.ARB_GOERLI_RPC }}" >> .env | ||
| echo ARB_MAINNET_RPC="${{ secrets.ARB_MAINNET_RPC }}" >> .env | ||
| cat .env | ||
|
There was a problem hiding this comment. maybe remove the cat, since we dont need to display the env There was a problem hiding this comment. I've removed the cat command and moved this entire "create .env" job into the env category that we had already. It runs successfully: https://github.com/open-dollar/od-relayer/actions/runs/7213145447/job/19652349583 |
||
|
|
||
| - name: Run Forge tests | ||
| run: | | ||
| forge test -vvv | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why cancel runs for other PRs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this section just makes sure that if someone is pushing several commits to the same branch/PR then it will cancel the one that's already in-progress and run just the latest one. I think it's useful if someone is developing on a specific PR for example and they push 3 commits in 2 minutes then it will make sure that only the latest job will be run to completion. do you think it's better to take it out?