Merge pull request #110 from kubeflow/main

[pull] main from kubeflow:main

.github/workflows/build.yml

@@ -22,22 +22,13 @@ jobs:
       - name: Setup Go
         uses: actions/setup-go@v5
         with:
-          go-version: '1.21'
-      - name: Install Protoc
-        uses: arduino/setup-protoc@v3
-        with:
-          version: "24.3"
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          go-version: "1.21"
       - name: Set up Python
         uses: actions/setup-python@v5
         with:
           python-version: 3.9
-      - name: Install makefile dependencies
-        run: make deps
-      - name: Clean
-        run: make clean
       - name: Build
-        run: make build
+        run: make clean build
       - name: Check if there are uncommitted file changes
         run: |
           clean=$(git status --porcelain)

Makefile

@@ -2,7 +2,7 @@
 MKFILE_PATH := $(abspath $(lastword $(MAKEFILE_LIST)))
 PROJECT_PATH := $(patsubst %/,%,$(dir $(MKFILE_PATH)))
 PROJECT_BIN := $(PROJECT_PATH)/bin
-GO := $(PROJECT_BIN)/go1.21.9
+GO ?= "$(shell which go)"
 
 # add tools bin directory
 PATH := $(PROJECT_BIN):$(PATH)
@@ -108,10 +108,6 @@ clean:
 clean/odh:
 	rm -Rf ./model-registry
 
-bin/go:
-	GOBIN=$(PROJECT_BIN) go install golang.org/dl/go1.21.9@latest
-	$(PROJECT_BIN)/go1.21.9 download
-
 bin/protoc:
 	./scripts/install_protoc.sh
 
@@ -155,7 +151,7 @@ clean/deps:
 	rm -Rf bin/*
 
 .PHONY: deps
-deps: bin/go bin/protoc bin/go-enum bin/protoc-gen-go bin/protoc-gen-go-grpc bin/golangci-lint bin/goverter bin/openapi-generator-cli
+deps: bin/protoc bin/go-enum bin/protoc-gen-go bin/protoc-gen-go-grpc bin/golangci-lint bin/goverter bin/openapi-generator-cli
 
 .PHONY: vendor
 vendor:

README.md

@@ -132,3 +132,19 @@ End-to-end testing is developed with Robot Framework; this higher-lever layer of
 - demonstrate *User Stories* from high level perspective
 - demonstrate coherent logical data mapping by performing the same high level capabilities, using REST API flow Vs Python client flow,
 directly checking the end results in the backend gRPC MLMD server.
+
+## Tips
+### Pull image rate limiting
+
+Ocassionally you may encounter an 'ImagePullBackOff' error when deploying the Model Registry manifests. See example below for the `model-registry-db` container. 
+
+```
+Failed to pull image “mysql:8.3.0”: rpc error: code = Unknown desc = fetching target platform image selected from image index: reading manifest sha256:f9097d95a4ba5451fff79f4110ea6d750ac17ca08840f1190a73320b84ca4c62 in docker.io/library/mysql: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
+```
+
+This error is triggered by the rate limits from docker.io; in this example specifically about the image `mysql:8.3.0` (the expanded reference is `docker.io/library/mysql:8.3.0`). To mitigate against this error you could [authenticate using image pull secrets](https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/) for _local development_; or replace the image used with alternative mirrored images, for instance with the following example:
+```
+manifests/kustomize/overlays/db/model-registry-db-deployment.yaml file.
+
+spec.template.spec.containers.image: public.ecr.aws/docker/library/mysql:8.3.0
+```

api/openapi/model-registry.yaml

@@ -1023,10 +1023,18 @@ components:
         - $ref: "#/components/schemas/BaseResourceList"
     RegisteredModelCreate:
       description: A registered model in model registry. A registered model has ModelVersion children.
+      required:
+        - name
       allOf:
         - type: object
         - $ref: "#/components/schemas/BaseResourceCreate"
         - $ref: "#/components/schemas/RegisteredModelUpdate"
+          properties:
+            name:
+              description: |-
+                The client provided name of the model. It must be unique among all the RegisteredModels of the same
+                type within a Model Registry instance and cannot be changed once set.
+              type: string
     RegisteredModelUpdate:
       description: A registered model in model registry. A registered model has ModelVersion children.
       allOf:
@@ -1045,6 +1053,7 @@ components:
     ModelVersionCreate:
       description: Represents a ModelVersion belonging to a RegisteredModel.
       required:
+        - name
         - registeredModelId
       allOf:
         - $ref: "#/components/schemas/BaseResourceCreate"
@@ -1054,6 +1063,11 @@ components:
             registeredModelId:
               description: ID of the `RegisteredModel` to which this version belongs.
               type: string
+            name:
+              description: |-
+                The client provided name of the model's version. It must be unique among all the ModelVersions of the same
+                type within a Model Registry instance and cannot be changed once set.
+              type: string
     ModelVersionUpdate:
       description: Represents a ModelVersion belonging to a RegisteredModel.
       allOf: