This commit removes servicemesh references in the DSCI file. It also … #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…removes sudo from the curl command
tonyxrmdavidson
requested review from
dhirajsb and
a team
and removed request for
tarilabs and
lampajr
rareddy
reviewed
Mar 28, 2024
| @@ -17,15 +17,3 @@ spec: | |||
| monitoring: | |||
| managementState: Managed | |||
| namespace: opendatahub | |||
| serviceMesh: | |||
There was a problem hiding this comment.
What does this mean, you are not installing the ServiceMesh anymore?
There was a problem hiding this comment.
No, not at all. Service mesh is still installed via the operator and the DSC. The DSCI shouldn't have it as that information will put into the DSCI file once service-mesh is installed.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rareddy, tonyxrmdavidson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…removes sudo from the curl command