Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This commit removes servicemesh references in the DSCI file. It also … #37

Merged
merged 1 commit into from
Mar 28, 2024
Merged

This commit removes servicemesh references in the DSCI file. It also … #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions openshift-ci/resources/model-registry-DSCInitialization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,3 @@ spec:
monitoring:
managementState: Managed
namespace: opendatahub
serviceMesh:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean, you are not installing the ServiceMesh anymore?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not at all. Service mesh is still installed via the operator and the DSC. The DSCI shouldn't have it as that information will put into the DSCI file once service-mesh is installed.

auth:
audiences:
- 'https://kubernetes.default.svc'
controlPlane:
metricsCollection: Istio
name: data-science-smcp
namespace: istio-system
managementState: Managed
trustedCABundle:
customCABundle: ''
managementState: Managed
2 changes: 1 addition & 1 deletion openshift-ci/scripts/install_yq.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ install_yq_if_not_installed() {
if ! command -v yq &>/dev/null; then
echo "yq is not installed. Installing..."
# Linux installation using curl
sudo curl -L https://github.com/mikefarah/yq/releases/download/3.4.1/yq_linux_amd64 -o /usr/local/bin/yq && sudo chmod +x /usr/local/bin/yq
curl -L https://github.com/mikefarah/yq/releases/download/3.4.1/yq_linux_amd64 -o /usr/local/bin/yq && sudo chmod +x /usr/local/bin/yq
else
echo "yq is already installed."
fi
Expand Down
Loading