-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA: require codecov token explicitly #78
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
=======================================
Coverage 75.84% 75.84%
=======================================
Files 19 19
Lines 2215 2215
Branches 101 101
=======================================
Hits 1680 1680
Misses 340 340
Partials 195 195 ☔ View full report in Codecov by Sentry. |
f11de94
to
0e72b5e
Compare
thank you @isinyaaa , it would look to me (based on separate tests from #79) the only actual change required is to bump the codecov action version i'm happy to merge this, just not sure about the "on workflow_call" as that to me looks like pertaining to workflow re-use (https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_call) which isn't at play here 🤔 or am I missing something? Let me know, then happy to merge it, many thanks again for investigating this!! 🙏 |
I got the impression that it was necessary for dependabot PRs. I can drop this change then. |
Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isinyaaa, tonyxrmdavidson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Attempt to fix the Python tests action (failing on #77).
How Has This Been Tested?
Merge criteria: