Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: require codecov token explicitly #78

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

isinyaaa
Copy link

Description

Attempt to fix the Python tests action (failing on #77).

How Has This Been Tested?

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.84%. Comparing base (ecaeffa) to head (af6ba5f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage   75.84%   75.84%           
=======================================
  Files          19       19           
  Lines        2215     2215           
  Branches      101      101           
=======================================
  Hits         1680     1680           
  Misses        340      340           
  Partials      195      195           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarilabs
Copy link
Member

thank you @isinyaaa , it would look to me (based on separate tests from #79) the only actual change required is to bump the codecov action version

i'm happy to merge this, just not sure about the "on workflow_call" as that to me looks like pertaining to workflow re-use (https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_call) which isn't at play here 🤔 or am I missing something?

Let me know, then happy to merge it, many thanks again for investigating this!! 🙏

@isinyaaa
Copy link
Author

thank you @isinyaaa , it would look to me (based on separate tests from #79) the only actual change required is to bump the codecov action version

i'm happy to merge this, just not sure about the "on workflow_call" as that to me looks like pertaining to workflow re-use (https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_call) which isn't at play here 🤔 or am I missing something?

I got the impression that it was necessary for dependabot PRs. I can drop this change then.

Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>
@tonyxrmdavidson
Copy link

/approve

@tonyxrmdavidson
Copy link

/lgtm

Copy link

openshift-ci bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isinyaaa, tonyxrmdavidson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [isinyaaa,tonyxrmdavidson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Jun 27, 2024
@isinyaaa isinyaaa merged commit 8d6ab38 into opendatahub-io:main Jun 27, 2024
13 checks passed
@isinyaaa isinyaaa deleted the codecov-trig branch June 27, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants