Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babeld: update to 1.13 #992

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

PolynomialDivision
Copy link
Member

@PolynomialDivision PolynomialDivision commented Jul 18, 2023

Announcement:
https://alioth-lists.debian.net/pipermail/babel-users/2023-July/004100.html

Babeld removed diversity routing [0], so we need to adjust ubus bindings. Further. we need to add a patch that makes local_kind accessible again: "100-local-make-local_kind-function-accessible.patch"

Refresh patches:

  • 600-add-ubus.patch

[0] - jech/babeld@a081608

Maintainer: me
Compile tested: mt7621, mt7622
Run tested: mt7622

Announcement:
https://alioth-lists.debian.net/pipermail/babel-users/2023-July/004100.html

Babeld removed diversity routing [0], so we need to adjust ubus
bindings. Further. we need to add a patch that makes local_kind
accessible again: "100-local-make-local_kind-function-accessible.patch"

Refresh patches:
- 600-add-ubus.patch

[0] - jech/babeld@a081608

Signed-off-by: Nick Hainke <vincent@systemli.org>
@PolynomialDivision PolynomialDivision merged commit 9e13652 into openwrt:master Jul 18, 2023
12 checks passed
@BKPepe
Copy link
Member

BKPepe commented Jul 19, 2023

You merged that within 40 minutes around midnight, in that time, trust me, no one will look at it. :-(

From b29cb705c3b717a7d5c61719936464438b9a48f0 Mon Sep 17 00:00:00 2001
From: Nick Hainke <vincent@systemli.org>
Date: Fri, 15 Jan 2021 15:01:31 +0100
Subject: [PATCH] local: make local_kind function accessible
Copy link
Member

@BKPepe BKPepe Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further. we need to add a patch that makes local_kind accessible again: "100-local-make-local_kind-function-accessible.patch"

Why do we need this patch? Did you try to send it to upstream?

It looks like to me without further looking into it that you are changing something that is not exactly wanted by upstream. They did it on purpose, didnt they?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I see that it is right now included in that repository, but you did not describe it anyhow in the OP. So, yes, it is better to include it instead of blindly adding patches, otherwise, the reviewer needs to spend more time if it is included in the upstream or it isnt. What I only found was this PR jech/babeld#72 2 years ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants