-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
babeld: update to 1.13 #992
Merged
PolynomialDivision
merged 1 commit into
openwrt:master
from
PolynomialDivision:babeld-1-13
Jul 18, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
babeld/patches/100-local-make-local_kind-function-accessible.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
From b29cb705c3b717a7d5c61719936464438b9a48f0 Mon Sep 17 00:00:00 2001 | ||
From: Nick Hainke <vincent@systemli.org> | ||
Date: Fri, 15 Jan 2021 15:01:31 +0100 | ||
Subject: [PATCH] local: make local_kind function accessible | ||
|
||
The kind-definitions are contained in the header file: | ||
LOCAL_FLUSH 0 | ||
LOCAL_ADD 1 | ||
LOCAL_CHANGE 2 | ||
|
||
The function (local_kind) that converts them into strings again | ||
is private. New addons (for example openwrt ubus bindings) that make | ||
use of babeld should also use the same function to convert the kind | ||
to string format. This allows to ensure uniformity over all addons. | ||
|
||
Signed-off-by: Nick Hainke <vincent@systemli.org> | ||
--- | ||
local.c | 2 +- | ||
local.h | 1 + | ||
2 files changed, 2 insertions(+), 1 deletion(-) | ||
|
||
--- a/local.c | ||
+++ b/local.c | ||
@@ -80,7 +80,7 @@ write_timeout(int fd, const void *buf, i | ||
} | ||
} | ||
|
||
-static const char * | ||
+const char * | ||
local_kind(int kind) | ||
{ | ||
switch(kind) { | ||
--- a/local.h | ||
+++ b/local.h | ||
@@ -55,3 +55,4 @@ int local_read(struct local_socket *s); | ||
int local_header(struct local_socket *s); | ||
struct local_socket *local_socket_create(int fd); | ||
void local_socket_destroy(int i); | ||
+const char *local_kind(int kind); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this patch? Did you try to send it to upstream?
It looks like to me without further looking into it that you are changing something that is not exactly wanted by upstream. They did it on purpose, didnt they?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jech/babeld@ef3eb65
jech/babeld@fe9407b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I see that it is right now included in that repository, but you did not describe it anyhow in the OP. So, yes, it is better to include it instead of blindly adding patches, otherwise, the reviewer needs to spend more time if it is included in the upstream or it isnt. What I only found was this PR jech/babeld#72 2 years ago.