-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port mhlo-quant-legalize-to-int pass to StableHLO #2383
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdasgup3
force-pushed
the
port-mhlo-quant-to-int
branch
from
June 7, 2024 00:50
c5177ad
to
ed488d7
Compare
sdasgup3
force-pushed
the
port-mhlo-quant-to-int
branch
from
June 7, 2024 01:08
ed488d7
to
794bfb5
Compare
GleasonK
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome to see!! Thanks for porting this, very excited to have this in the repo for all to use / contribute to.
sdasgup3
force-pushed
the
port-mhlo-quant-to-int
branch
from
June 7, 2024 06:55
6214df3
to
83090fe
Compare
This was referenced Jun 7, 2024
GleasonK
pushed a commit
that referenced
this pull request
Jun 10, 2024
Originally brought up at #2383 (comment) The `stablehlo-legalize-quant-to-int` pass propagated from mho (#2383 ) uses std::variant to handle per-tensor and per-axis quantized type. However, the base class quant::QuantizedType provides a better polymorphic way to accomplish the same. ## Direction to reviewers Please review the change only in the following commit: ee8b499 Reason: This PR is based on #2383 which is not merged yet and hence has many files which are already reviewed as part of #2383.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the port of mhlo-quant-legalize-to-int pass to Stablehlo.
A bunch of tests needs to be updates based on:
DenseIntElementsAttr
toI64ArrayAttr
)Also, updated the original code to address creation of attributes of type
I64ArrayAttr
instead ofDenseIntElementsAttr
.