-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interpreter support for quantized type #2388
Conversation
88c639f
to
4d7dc1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this approach is fine, but I thought the point of the reference interpreter was to show how the various operations work. Would it be much more onerous to implement support for uniform_quantize
and uniform_dequantize
directly?
4d7dc1a
to
bd607c0
Compare
94f16aa
to
509f4a7
Compare
That is a very good point! The idea here is to handle all the quantized operation uniformly. That means, either (A) Support the execution semantics of all the quantized operations (uniform_quantize, uniform_dequantize, and any other operations which support quantized types) natively in the interpreter, OR (B) is the fastest path towards evaluating quantize program. |
509f4a7
to
5eea628
Compare
3ca19aa
to
cdf55ac
Compare
fixes #2373
The PR is rebased on top on #2383 and cherry-pick changes from #2384.
Direction to reviewer
Please review the commit 4d7dc1a excluding the following files