Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hanging UI thread for certain AudioContext::suspend/stop actions #499

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

orottier
Copy link
Owner

There were quite a few issues with

  • multiple subsequent suspend() calls
  • multiple subsequent close() calls
  • calling close() on a suspended context

There are regression tests for these cases now.

CC @ggadwa

There were quite a few issues with
- multiple subsequent suspend() calls
- multiple subsequent close() calls
- calling close() on a suspended context

There are regression tests for these cases now.

Fixes #496
@orottier orottier requested a review from b-ma April 18, 2024 18:18
src/context/concrete_base.rs Outdated Show resolved Hide resolved
Co-authored-by: Benjamin Matuszewski <benjamin.matuszewski@gmail.com>
@orottier orottier merged commit cb43d87 into main Apr 19, 2024
3 checks passed
@orottier orottier deleted the bugfix/double-suspend-hangs branch April 19, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants