Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hanging UI thread for certain AudioContext::suspend/stop actions #499

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Fix hanging UI thread for certain AudioContext::suspend/stop actions #499

merged 4 commits into from
Apr 19, 2024

Commits on Apr 18, 2024

  1. Add logging for AudioContext::suspend/close/resume/setSinkId

    @orottier
    orottier committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    3364d53 View commit details
    Browse the repository at this point in the history

  2. Fix hanging UI thread for certain AudioContext::suspend/stop actions 

    There were quite a few issues with
- multiple subsequent suspend() calls
- multiple subsequent close() calls
- calling close() on a suspended context

There are regression tests for these cases now.

Fixes #496
    @orottier
    orottier committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    c384fba View commit details
    Browse the repository at this point in the history

  3. Use sink_id "none" for all suspend/resume tests

    @orottier
    orottier committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    8965534 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Update src/context/concrete_base.rs 

    Co-authored-by: Benjamin Matuszewski <benjamin.matuszewski@gmail.com>
    @orottier @b-ma
    orottier and b-ma authored Apr 19, 2024
    Configuration menu
    Copy the full SHA
    1c36f8e View commit details
    Browse the repository at this point in the history