Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement token lifespans config from hydra-maester #691

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

David-Wobrock
Copy link
Contributor

Related Issue or Design Document

Relates to ory/hydra-maester#145

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@David-Wobrock David-Wobrock changed the title Implement token lifespans config from hydra-maester. feat: implement token lifespans config from hydra-maester Jun 16, 2024
@David-Wobrock David-Wobrock force-pushed the feat/handle-token-lifespans branch from 5d02846 to fd45483 Compare June 16, 2024 11:19
@David-Wobrock David-Wobrock marked this pull request as ready for review June 16, 2024 11:23
@Demonsthere
Copy link
Collaborator

Hi there! The changes will be live in https://github.com/ory/hydra-maester/releases/tag/v0.0.34, can you please bump the default image in the PR? Also, the CRD may have changed since this PR was creates, as we had to update the internals of the maester, please verify :)

@David-Wobrock David-Wobrock force-pushed the feat/handle-token-lifespans branch 3 times, most recently from 982a713 to 8f39063 Compare June 25, 2024 06:43
@David-Wobrock David-Wobrock force-pushed the feat/handle-token-lifespans branch from 8f39063 to 6dc6a85 Compare June 25, 2024 06:53
@David-Wobrock
Copy link
Contributor Author

Hi there! The changes will be live in https://github.com/ory/hydra-maester/releases/tag/v0.0.34, can you please bump the default image in the PR? Also, the CRD may have changed since this PR was creates, as we had to update the internals of the maester, please verify :)

Hey @Demonsthere 👋
Thanks for the release of the new image.

I updated the branch with the new version, and I think the CRD is up to date 🤔
Let me know if something is missing.

Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Demonsthere Demonsthere merged commit d3e4598 into ory:master Jun 25, 2024
10 checks passed
@David-Wobrock David-Wobrock deleted the feat/handle-token-lifespans branch June 25, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants