Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement handling token lifespans #145

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

David-Wobrock
Copy link
Contributor

@David-Wobrock David-Wobrock commented Jun 16, 2024

Allow setting various Hydra OAuth2 client token lifespans through hydra-maester.

Related Issue or Design Document

Fixes #112

Relates to ory/k8s#691

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@David-Wobrock David-Wobrock changed the title Implement handling token lifespans. feat: implement handling token lifespans Jun 16, 2024
@David-Wobrock David-Wobrock marked this pull request as ready for review June 16, 2024 11:23
Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the branch, and take a look at the tests, i see they are failing with unexpected errors

@David-Wobrock David-Wobrock force-pushed the feat/handle-token-lifespans branch 3 times, most recently from 51e123a to 0cb8255 Compare June 23, 2024 11:46
@David-Wobrock David-Wobrock force-pushed the feat/handle-token-lifespans branch from 0cb8255 to 3fb3c51 Compare June 23, 2024 11:47
@David-Wobrock
Copy link
Contributor Author

Please update the branch, and take a look at the tests, i see they are failing with unexpected errors

Thanks, I updated the branch.

The Docker image scan is failing because of CVEs is older Golang versions.
I guess we can fix that in a next patch :)

@Demonsthere
Copy link
Collaborator

Demonsthere commented Jun 24, 2024

Please update the branch, and take a look at the tests, i see they are failing with unexpected errors

Thanks, I updated the branch.

The Docker image scan is failing because of CVEs is older Golang versions. I guess we can fix that in a next patch :)

I have updated the internals for golang 1.22 and k8s, please see #147 and rebase ;)

@David-Wobrock David-Wobrock force-pushed the feat/handle-token-lifespans branch from 3fb3c51 to 5895a16 Compare June 24, 2024 11:23
@David-Wobrock
Copy link
Contributor Author

Thanks @Demonsthere

Rebased and pushed the updated branch.

@Demonsthere Demonsthere merged commit 8f679ba into ory:master Jun 24, 2024
12 checks passed
@David-Wobrock David-Wobrock deleted the feat/handle-token-lifespans branch June 24, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new TokenTTL configs from Hydra
2 participants