Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect selection of VPN preset #996

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

keeshux
Copy link
Member

@keeshux keeshux commented Dec 10, 2024

Drop "Any" to rather make the preset filter an explicit preset selection.

Regardless of filtersWithSelection, always enforce the preset filter to:

  • The preset of the currently selected entity
  • The first among available presets (normally non-empty)

Fixes #995

@keeshux keeshux self-assigned this Dec 10, 2024
@keeshux keeshux added the bug Something isn't working label Dec 10, 2024
@keeshux keeshux added this to the 3.0.0 / 6. Freeze milestone Dec 10, 2024
@keeshux keeshux merged commit c7bba03 into master Dec 10, 2024
1 check passed
@keeshux keeshux deleted the bugfix/unclear-server-preset branch December 10, 2024 13:45
keeshux added a commit that referenced this pull request Dec 12, 2024
keeshux added a commit that referenced this pull request Dec 12, 2024
Revert #996 and do something midway:

- When set, use preset filter as selection (disambiguate compatible
presets)
- Set initial preset filter with current selected server preset

Server selection still picks a random preset if:

- Preset filter is "Any"
- More than one preset is compatible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Incorrect preset selected
1 participant