Skip to content

Commit

Permalink
Release v0.8.0
Browse files Browse the repository at this point in the history
  • Loading branch information
Thomas Neitmann authored Sep 6, 2022
2 parents dfb6489 + 7e1b1ba commit ed849a6
Show file tree
Hide file tree
Showing 402 changed files with 17,056 additions and 12,451 deletions.
3 changes: 3 additions & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,6 @@
^admiral\.Rcheck$
^admiral.*\.tar\.gz$
^admiral.*\.tgz$
^\.lycheeignore$
^staged_dependencies.yaml$
^inst/dev_dependencies.R$
4 changes: 2 additions & 2 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
# Contribution to {admiral}

This outlines how to propose a change to the admiral package. For more detailed info about contributing to {admiral}, and other [pharmaverse packages](https://pharmaverse.org/), please see the [development process guide](https://pharmaverse.github.io/admiral/articles/development_process.html) as well as other Developer Guides in the Articles section of the [{admiral} website](https://pharmaverse.github.io/admiral/index.html)
This outlines how to propose a change to the admiral package. For more detailed info about contributing to {admiral}, and other [pharmaverse packages](https://pharmaverse.org/), please see the [development process guide](https://pharmaverse.github.io/admiraldev/main/articles/development_process.html) as well as other Developer Guides in the Articles section of the [{admiral} website](https://pharmaverse.github.io/admiral/index.html)

# Basics
* For each new contribution, the user creates an issue on the issue tab on [GitHub](https://github.com/pharmaverse/admiral/issues) to put it in our backlog. The issues can range from bug identification and/or fixes, enhancements to functions, documentation, tests or new features.

* We advise you to contact us when an [issue](https://github.com/pharmaverse/admiral/issues) is created via [Slack](https://app.slack.com/client/T028PB489D3/C02M8KN8269) (If you don't have access, use this [link](https://join.slack.com/t/pharmaverse/shared_invite/zt-yv5atkr4-Np2ytJ6W_QKz_4Olo7Jo9A) to join). We can discuss details or align expectations if you are not familiar with the `{admiral}` philosophy and programming strategy. The team will try to review the issues within the next backlog meeting and give some initial feedback. Since we are not a 100% fully resourced software development team it might be that some issues will take longer to respond to depending on the amount of overall issues.

* Familiarize yourself with our [programming strategy](https://pharmaverse.github.io/admiral/articles/programming_strategy.html), guidance for [GitHub usage](https://pharmaverse.github.io/admiral/articles/git_usage.html) and [unit testing](https://pharmaverse.github.io/admiral/articles/unit_test_guidance.html).
* Familiarize yourself with our [programming strategy](https://pharmaverse.github.io/admiraldev/main/articles/programming_strategy.html), guidance for [GitHub usage](https://pharmaverse.github.io/admiraldev/main/articles/git_usage.html) and [unit testing](https://pharmaverse.github.io/admiraldev/main/articles/unit_test_guidance.html).

* All newly [created issues](https://github.com/pharmaverse/admiral/issues) will be reviewed within the next backlog meeting and the creator will receive an initial feedback via a comment. Someone from the core development team will then triage new issues by assigning the appropriate labels (such as “user request” so we can easily identify new requests).

Expand Down
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/05_onboard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ body:
- label: Given a tour of Github from a Core member
- label: Understand how to Create Issues and do a Pull Request
- label: Understand the Programming Strategy
- label: Read and understand [Developer Guides Articles](https://pharmaverse.github.io/admiral/index.html)
- label: Read and understand [Developer Guides Articles](https://pharmaverse.github.io/admiraldev/main/articles/development_process.html)
- label: Invited to all relevant meetings - Stand Ups, Question/Comments, Backlog, Community Meeting
- label: Given access to Box and relevant documents
- label: Given write access to Github Repository
Expand All @@ -33,7 +33,7 @@ body:
- label: Given a tour of Github from a Core member
- label: Understand how to Create Issues and do a Pull Request
- label: Understand the Programming Strategy
- label: Read and understand [Developer Guides Articles](https://pharmaverse.github.io/admiral/index.html)
- label: Read and understand [Developer Guides Articles](https://pharmaverse.github.io/admiraldev/main/articles/development_process.html)
- label: Invited to all relevant meetings - Question/Comments, Community Meeting
- label: Given write access to Github Repository
- label: Slack channel invites to admiral
Expand Down
9 changes: 7 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE/release.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,16 @@
- [ ] Website is deployed and visual checks for integrity completed
- [ ] Prepare and Post announcements for Linked-In and Slack Channels for Release


# Clean up Checklist
<!--- Fill out the following Clean up checklist -->
- [ ] Delete patch and pre-release branches
- [ ] Delete branches that are stale or abandoned or leftover from a Pull Request
- [ ] Triage and close issues that were not closed properly via PRs that made it into release
- [ ] Close Pull Requests that are stale
- [ ] Set up and increment News/Changelog Skeleton
- [ ] Set up and increment News/Changelog Skeleton and Description File
- [ ] Retire labels specific to a time-period (testing feedback) if no longer in use
- [ ] Remove Users with no acitivty for 12 months from Repository
- [ ] Remove Users with no activity for 12 months from Repository
- [ ] Update Release Schedule on Readme and Github Vignette with new Quarters and Dates
- [ ] Verify any pre-release or patch updates are appropriately merged into devel

8 changes: 4 additions & 4 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@

Thank you for your Pull Request! We have developed this task checklist from the [Development Process Guide](https://pharmaverse.github.io/admiral/articles/development_process.html) to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Thank you for your Pull Request! We have developed this task checklist from the [Development Process Guide](https://pharmaverse.github.io/admiraldev/main/articles/development_process.html) to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the `devel` branch until you have checked off each task.

- [ ] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
- [ ] Code is formatted according to the [tidyverse style guide](https://style.tidyverse.org/)
- [ ] Updated relevant unit tests or have written new unit tests - See [Unit Test Guide](https://pharmaverse.github.io/admiral/articles/unit_test_guidance.html#writing-unit-tests-in-admiral-)
- [ ] If you removed/replaced any function and/or function parameters, did you fully follow the [deprecation guidance](https://pharmaverse.github.io/admiral/articles/programming_strategy.html#deprecation-1)?
- [ ] Code is formatted according to the [tidyverse style guide](https://style.tidyverse.org/). Run `styler::style_file()` to style R and Rmd files
- [ ] Updated relevant unit tests or have written new unit tests - See [Unit Test Guide](https://pharmaverse.github.io/admiraldev/main/articles/unit_test_guidance.html#writing-unit-tests-in-admiral-)
- [ ] If you removed/replaced any function and/or function parameters, did you fully follow the [deprecation guidance](https://pharmaverse.github.io/admiraldev/main/articles/programming_strategy.html#deprecation-1)?
- [ ] Update to all relevant roxygen headers and examples
- [ ] Run `devtools::document()` so all `.Rd` files in the `man` folder and the `NAMESPACE` file in the project root are updated appropriately
- [ ] Address any updates needed for vignettes and/or templates
Expand Down
94 changes: 0 additions & 94 deletions .github/workflows/R-CMD-check.yml

This file was deleted.

71 changes: 0 additions & 71 deletions .github/workflows/check_templates.yml

This file was deleted.

Loading

0 comments on commit ed849a6

Please sign in to comment.