Skip to content
This repository has been archived by the owner on Nov 6, 2019. It is now read-only.

Add ARIA roles to tabs #406

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Conversation

jasongrout
Copy link
Member

This builds on #405 to also add ARIA roles to tabs. Merge #405 first.

zorkow and others added 23 commits July 26, 2019 15:57
This commit also does some stylistic changes as well, like capitalizing ARIA and treating it like the other generic attributes.
According to experts (including both an invited expert advisor and a co-chair of ARIA committee), aria-controls is not needed, and actually annoying in JAWS.
Also use the tab bar orientation setter to set the default orientation.
Before, we needed to clamp down on these types for aria attributes. This is (a) backwards incompatible and (b) not needed anymore.
@@ -893,6 +914,9 @@ class TabBar<T> extends Widget {
let ci = this._currentIndex;
let bh = this.insertBehavior;


// TODO: do we need to do an update to update the aria-selected attribute?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afshin points out that the two TODO items should be taken care of. Agreed. In a later version I just deleted the two notes, which may indicate that I thought about it and decided it wasn't necessary. That should be double-checked.

@vidartf
Copy link
Contributor

vidartf commented Jul 27, 2019

For reference, this is a comparison between this PR's branch, and that of #405: jasongrout/phosphor@aria-menus...jasongrout:aria-tabs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants