This repository has been archived by the owner on Nov 6, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 169
Add ARIA roles to tabs #406
Open
jasongrout
wants to merge
23
commits into
phosphorjs:master
Choose a base branch
from
jasongrout:aria-tabs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
5df47af
Adds the menubar role.
zorkow e78d268
Adds initial set of aria roles to the menu.
zorkow 390dea1
Refactors Aria Attributes into separate type.
zorkow eda2953
Adds Aria attributes to be treated special.
zorkow b034300
Adds roles and popup to all menu items. Corrects separator.
zorkow 7de5cde
Add all ARIA attributes from the standard.
jasongrout b0cb6e8
Change to separator role.
zorkow 660763c
Fix typo
jasongrout 91e2adf
Fix formatting and variable names for menus
jasongrout 547f73c
Add tab and tablist ARIA attributes for tabs.
jasongrout 09e01c7
Add tab aria attributes in constructor.
jasongrout 67860c6
Initial draft of adding tabpanel aria data for tabpanel and dockpanel.
jasongrout f6c56aa
Add aria-label and aria-selected to tab bars.
jasongrout 0eba6f2
Remove aria-controls.
jasongrout cc3ef02
Add tab bar names, and default to “Activities <number>” for dockpanel.
jasongrout a73bdd3
Keep application-specific things out of phosphor.
jasongrout cef9b8a
Clean up tab panel adding widget ids and assuming tab bars are rendered.
jasongrout e193761
Fix formatting and variable names for tabpanel
jasongrout 85951ae
Revert changes to default tab renderer and tab type parameters.
jasongrout 272cc7e
Add documentation for createTabKey.
jasongrout b7914f7
Always set the aria attributes for a tab panel.
jasongrout 4eab2dc
Add two TODO notes about where the tab aria-selected state might need…
jasongrout 9121c4d
Only create tab keys if we have a tab bar renderer.
jasongrout File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afshin points out that the two TODO items should be taken care of. Agreed. In a later version I just deleted the two notes, which may indicate that I thought about it and decided it wasn't necessary. That should be double-checked.