planner, executor: fix the logic for inline projection of executors (#45158) #45332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
12 tasks
ti-chi-bot
added
release-note-none
ti-chi-bot
added
the
cherry-pick-approved
fixdb
reviewed
Jul 12, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #45332 +/- ##
================================================
Coverage ? 73.6609%
================================================
Files ? 1083
Lines ? 347438
Branches ? 0
================================================
Hits ? 255926
Misses ? 75067
Partials ? 16445 |
qw4990
approved these changes
Aug 15, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
time-and-fate
approved these changes
Aug 15, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, time-and-fate The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #45158
What problem does this PR solve?
Issue Number: close #45112
Problem Summary:
What is changed and how it works?
The Physical Projection Elimination permits the case that the parent plan has a column which cannot be found by the child(ren).
The only thing we can rely on during the execution phase is the
Column.Index.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.