-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: support rollback from higher version to 6.5 #45762
Conversation
/retest |
Please add UT cover change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #45762 +/- ##
================================================
Coverage ? 73.6919%
================================================
Files ? 1083
Lines ? 347205
Branches ? 0
================================================
Hits ? 255862
Misses ? 74937
Partials ? 16406 |
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Issue Number: close #45570
Problem Summary:
We checked DDLTableVersion == 2 in 6.5, but it may be set to a higher value in a higher version TiDB.
What is changed and how it works?
check DDLTableVersion >= 2, which is the same as the fixed in the higher version.
Check List
Tests
Unit test
Integration test
Manual test (add detailed scripts or steps below)
Start a master cluster, then use this PR to start a TiDB server. It can start normally.
No code
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.