-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: reset lexer.identifierDot
correctly when reusing parsers (#45903)
#45909
parser: reset lexer.identifierDot
correctly when reusing parsers (#45903)
#45909
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
/retest-required |
/retest |
1 similar comment
/retest |
/retest-required |
/retest-required |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #45909 +/- ##
================================================
Coverage ? 73.7499%
================================================
Files ? 1084
Lines ? 348365
Branches ? 0
================================================
Hits ? 256919
Misses ? 75009
Partials ? 16437 |
/test unit-test |
@Ivy-YinSu: No presubmit jobs available for pingcap/tidb@release-6.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #45903
What problem does this PR solve?
Issue Number: close #45898
Problem Summary: parser: reset
lexer.identifierDot
correctly when reusing parsersWhat is changed and how it works?
parser: reset
lexer.identifierDot
correctly when reusing parsersCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.