Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: replace exp/slices with std #45986

Merged
merged 6 commits into from
Aug 11, 2023
Merged

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 11, 2023

What problem does this PR solve?

Issue Number: ref #45933

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 11, 2023
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #45986 (12fedc7) into master (6fb20c9) will decrease coverage by 2.0922%.
Report is 11 commits behind head on master.
The diff coverage is 50.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45986        +/-   ##
================================================
- Coverage   74.7832%   72.6911%   -2.0922%     
================================================
  Files          1293       1300         +7     
  Lines        397930     399705      +1775     
================================================
- Hits         297585     290550      -7035     
- Misses        80979      90696      +9717     
+ Partials      19366      18459       -907     
Flag Coverage Δ
integration 25.5605% <0.0000%> (-20.9416%) ⬇️
unit 73.3648% <60.0000%> (+0.0184%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0494% <ø> (ø)
br 47.6243% <50.0000%> (-17.0727%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. and removed do-not-merge/needs-linked-issue labels Aug 11, 2023
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

br/pkg/lightning/lightning.go Outdated Show resolved Hide resolved
br/pkg/restore/db.go Outdated Show resolved Hide resolved
hawkingrei and others added 2 commits August 11, 2023 11:50
Co-authored-by: D3Hunter <jujj603@gmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-11 01:52:10.738812475 +0000 UTC m=+250295.287828461: ☑️ agreed by lance6716.
  • 2023-08-11 03:57:46.160970342 +0000 UTC m=+257830.709986327: ☑️ agreed by D3Hunter.

@ti-chi-bot ti-chi-bot bot merged commit 66033d5 into pingcap:master Aug 11, 2023
7 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants