-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: Fix coroutine leak after kill remote connection (#46035) #46065
executor: Fix coroutine leak after kill remote connection (#46035) #46065
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Ping Yu <yuping@pingcap.com>
/test mysql-test |
@pingyu: No presubmit jobs available for pingcap/tidb@release-6.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test mysql-test |
@pingyu: No presubmit jobs available for pingcap/tidb@release-6.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #46065 +/- ##
================================================
Coverage ? 73.6527%
================================================
Files ? 1083
Lines ? 347737
Branches ? 0
================================================
Hits ? 256118
Misses ? 75168
Partials ? 16451 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #46035
What problem does this PR solve?
Issue Number: close #46034
Problem Summary: Coroutine leak after kill remote connection.
What is changed and how it works?
Close
resp
of coprocessor request. Otherwise the coprocessor will be blocked on therespChan
.Check List
Tests
Run the same test in issue, the coroutine count was stable, and no OOM occurred.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.