Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: fix incorrect _tidb_rowid allocator value after import for table with AUTO_ID_CACHE=1 (#46171) #46183

Merged
merged 6 commits into from
Aug 18, 2023
Merged

lightning: fix incorrect _tidb_rowid allocator value after import for table with AUTO_ID_CACHE=1 (#46171) #46183

merged 6 commits into from
Aug 18, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #46171

What problem does this PR solve?

Issue Number: close #46100

Problem Summary:

since TiDB v6.5.0, we have separate id allocator for _tidb_rowid and auto_increment id when AUTO_ID_CACHE=1, see #39041, and ALTER TABLE x AUTO_INCREMENT=x only works on the allocator of auto_increment in this case, but if the table have implicit _tidb_rowid, we should update it's base too to make sure new insert works, else it will report duplicate entry

What is changed and how it works?

  • rebase on both allocators when needed after import

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@D3Hunter @ti-chi-bot
This is an automated cherry-pick of pingcap#46171
a992cd7 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Aug 17, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Aug 17, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 17, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 17, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 17, 2023
@D3Hunter
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 18, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 18, 2023
@D3Hunter
Copy link
Contributor

/run-integration-br-test

@D3Hunter
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 18, 2023

@D3Hunter: Your lgtm message is repeated, so it is ignored.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-18 02:40:52.565650497 +0000 UTC m=+858017.114666471: ☑️ agreed by D3Hunter.
  • 2023-08-18 03:08:40.419509518 +0000 UTC m=+859684.968525505: ☑️ agreed by lance6716.

@D3Hunter
Copy link
Contributor

/retest

@D3Hunter
Copy link
Contributor

/hold

wait ci

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2023
@D3Hunter
Copy link
Contributor

/run-integration-br-test

6 similar comments
@D3Hunter
Copy link
Contributor

/run-integration-br-test

@D3Hunter
Copy link
Contributor

/run-integration-br-test

@D3Hunter
Copy link
Contributor

/run-integration-br-test

@D3Hunter
Copy link
Contributor

/run-integration-br-test

@Ivy-YinSu
Copy link

/run-integration-br-test

@Ivy-YinSu
Copy link

/run-integration-br-test

@D3Hunter
Copy link
Contributor

/run-integration-br-test

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@07c1326). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #46183   +/-   ##
================================================
  Coverage               ?   73.6722%           
================================================
  Files                  ?       1084           
  Lines                  ?     347945           
  Branches               ?          0           
================================================
  Hits                   ?     256339           
  Misses                 ?      75155           
  Partials               ?      16451

@D3Hunter
Copy link
Contributor

/run-integration-br-test

@D3Hunter
Copy link
Contributor

/run-integration-br-test

@D3Hunter
Copy link
Contributor

/run-integration-br-test

@D3Hunter
Copy link
Contributor

/retest

@D3Hunter
Copy link
Contributor

lightning ci pass, some br cases are so unstable, we won't wait them, as this pr only change lightning part

https://ci.pingcap.net/blue/organizations/jenkins/br_ghpr_unit_and_integration_test/detail/br_ghpr_unit_and_integration_test/16112/pipeline/117

those cases're run locally, success
lightning_alter_random
lightning_auto_columns
lightning_auto_random_default

@D3Hunter
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit 8c8799e into pingcap:release-6.5 Aug 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

Assignees

@D3Hunter D3Hunter

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @D3Hunter @Ivy-YinSu @lance6716