Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: refactor phase 1 cleanup files #49626

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Dec 20, 2023

What problem does this PR solve?

Issue Number: close #41241

Problem Summary:

What changed and how does it work?

This PR is the phase 1 change of BR reorg. It removes some unnecessary files.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 20, 2023
@BornChanger BornChanger changed the title Br refactor cleanup files br: refactor phase 1 cleanup files Dec 20, 2023
@BornChanger BornChanger force-pushed the br_refactor_cleanup_files branch from eb20af4 to 90fc471 Compare December 20, 2023 10:33
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.1400%. Comparing base (d18ee3f) to head (b13185e).
Report is 2611 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #49626         +/-   ##
=================================================
+ Coverage   70.9796%   81.1400%   +10.1603%     
=================================================
  Files          1368       2502       +1134     
  Lines        398769     727939     +329170     
=================================================
+ Hits         283045     590650     +307605     
- Misses        95948     115879      +19931     
- Partials      19776      21410       +1634     
Flag Coverage Δ
integration 52.2021% <ø> (?)
unit 79.4265% <ø> (+8.4468%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 73.6130% <ø> (+19.6466%) ⬆️
parser ∅ <ø> (∅)
br 67.5990% <ø> (+14.7168%) ⬆️

@BornChanger
Copy link
Contributor Author

/cc @3pointer @YuJuncen @Leavrth

@BornChanger
Copy link
Contributor Author

/cc @bb7133

@ti-chi-bot ti-chi-bot bot requested a review from bb7133 December 20, 2023 12:33
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger BornChanger force-pushed the br_refactor_cleanup_files branch from 90fc471 to b13185e Compare December 20, 2023 13:11
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2024
Copy link

ti-chi-bot bot commented Mar 29, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 29, 2024
Copy link

ti-chi-bot bot commented Apr 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-29 04:22:49.681024414 +0000 UTC m=+244723.438159987: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 29, 2024
@dveeden
Copy link
Contributor

dveeden commented Sep 20, 2024

@BornChanger what is the status of this? should this be merged once the conflicts are fixed or should it be closed?

Copy link

ti-chi-bot bot commented Nov 18, 2024

@BornChanger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test b13185e link true /test mysql-test
pull-lightning-integration-test b13185e link true /test pull-lightning-integration-test
pull-br-integration-test b13185e link true /test pull-br-integration-test
pull-integration-e2e-test b13185e link true /test pull-integration-e2e-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: reorganize packages layout for this repository
3 participants