planner: remove the limitation that predicates can't be pushed through Projection
on TableDual
(#51329)
#52166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #51329
What problem does this PR solve?
Issue Number: close #50614
Problem Summary:
#35669 disables predicates pushdown on
TableDual
.This usually won't cause problems, but when it comes to cases like #50614, many unnecessary predicates with lots of conditions will cause obvious performance regression.
What changed and how does it work?
This PR reverts #35669, which is for fixing #35527.
#35527 itself has already been fixed by #38802, which prevents predicates from being incorrectly pushed through
Projection
.As said in #35669, sometimes
TableDual
doesn't have aschema
. This may or may not be considered as a mistake depending on our definition of the semantic ofTableDual
.Anyway,
TableDual
withoutschema
should not cause a problem if the predicates are pushed down correctly.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.