-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: don't cast collation for in expression is the new collation is disabled (#52812) #52864
expression: don't cast collation for in expression is the new collation is disabled (#52812) #52864
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #52864 +/- ##
================================================
Coverage ? 73.4322%
================================================
Files ? 1211
Lines ? 380118
Branches ? 0
================================================
Hits ? 279129
Misses ? 83163
Partials ? 17826 |
This is an automated cherry-pick of #52812
What problem does this PR solve?
Issue Number: close #52772
Problem Summary:
If the new collation is disabled, we should not cast collation for in expression, which may lead to panic in the issue case.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.