Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix data race in scan locks #57299

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Nov 11, 2024

What problem does this PR solve?

Issue Number: close #57298
Problem Summary:
As title.

What changed and how does it work?

add mutex for race functions.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented Nov 11, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 11, 2024
Copy link

tiprow bot commented Nov 11, 2024

Hi @3pointer. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@3pointer 3pointer marked this pull request as ready for review November 11, 2024 11:55
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.5687%. Comparing base (3047328) to head (86f1aba).
Report is 110 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57299        +/-   ##
================================================
+ Coverage   72.9496%   74.5687%   +1.6191%     
================================================
  Files          1667       1682        +15     
  Lines        460833     460933       +100     
================================================
+ Hits         336176     343712      +7536     
+ Misses       103971      95920      -8051     
- Partials      20686      21301       +615     
Flag Coverage Δ
integration 46.6652% <ø> (?)
unit 72.2950% <ø> (-0.0480%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 60.7815% <ø> (+15.7077%) ⬆️
---- 🚨 Try these New Features:

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 11, 2024
Copy link

ti-chi-bot bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 11, 2024
Copy link

ti-chi-bot bot commented Nov 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-11 12:32:57.079839719 +0000 UTC m=+273139.270708717: ☑️ agreed by YuJuncen.
  • 2024-11-11 13:24:52.918363342 +0000 UTC m=+276255.109232344: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot bot merged commit 6528da5 into pingcap:master Nov 11, 2024
34 of 36 checks passed
@3pointer 3pointer added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 22, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 22, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #57630.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data race in TestResolveLock
4 participants